Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow static or dynamic error pages #81

Open
HHHartmann opened this issue Mar 15, 2017 · 1 comment
Open

Allow static or dynamic error pages #81

HHHartmann opened this issue Mar 15, 2017 · 1 comment

Comments

@HHHartmann
Copy link
Contributor

The idea is to alter the filename of the request and remember, that it is an error url. and then reprocess it.
I am afraid this will require some refactoring
I would suggest to use a new name scheme for error pages to allow displaying them in unauthorized mode and prevent calling them directly
like
error/404.* for a 404 error and the like.

What do you think?

HHHartmann added a commit to HHHartmann/nodemcu-httpserver that referenced this issue Apr 19, 2017
allow individual errorpages, selected based on http result code and
fille extension.
@marcoskirsch
Copy link
Owner

Customizable error pages seem like overkill for such a simple server but I'm not strongly opposed.
Storing them under "error/404.html" as you suggest sounds like the way to go to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants