add dynamic errorhandling #83
Conversation
Add new todo which I am working on already. Basically to learn contributing
In AP mode wifi.sta.getip is nil
if you give the MIME type it will be mapped to text/plain
…HTTP Status string Add all HTTP response codes used in the project allow extra headers to be passed return the response code string e.g.: return "Not found" for code 404 (needed in new error implementation)
now uses httpserver-error.lua to print the header
allow individual errorpages, selected based on http result code and fille extension.
The parameter should be the connection itself. Log then calls getpeer on it
sometimes I observe requests which are malformed (seem to be binary data) so everything that does not have a method and request (url) defined gets kicked.
make cars dynamic to load 1 to 4 cars
plus some more commented out prints
|
For starting: List of MIME types You can't change "text/html" to just "html" and "application/json" to "json". |
|
Thanks for reviewing the changes. |
| @@ -1,21 +0,0 @@ | |||
| <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"> | |||
There was a problem hiding this comment.
I'd like to keep this around, it's useful to show the limitations of the server. I'm all for teaching clients how to work around said limitations, but it should be in a separate file.
Someone was supposed to do a pull request in which the workaround is based on having the served page include javascript to request the car images serially. I can see us having both examples included.
Can you do a separate PR in which you show your cars.lua workaround and leave this one in place? I'd rather do one pull request per logical change, this one bundles several.
Thanks!
There was a problem hiding this comment.
Hi,
glad you find some time to have a closer look.
The old cars.html example will work as well with the changes herein. But if it is to try the other approach I can put it back in.
I just created the cars.lua since I was too lazy to change the sources every time I want to test a different number of cars. It generates pretty much the same page as the cars.html.
As to the big PR:
I developed offline and then tried to separate the chenges inseparate checkins. They build up on each other. Cause of that it would be quite difficult to extract each feature/fix in a separate PR.
Id like to avoid that.
| @@ -1,5 +1,5 @@ | |||
| local function sendAttr(connection, attr, val) | |||
| connection:send("<li><b>".. attr .. ":</b> " .. val .. "<br></li>\n") | |||
| connection:send("<li><b>".. attr .. ":</b> " .. (val or "nil") .. "<br></li>\n") | |||
There was a problem hiding this comment.
this improvement could be its own PR as well.
There was a problem hiding this comment.
Will do a separate PR here.
| @@ -0,0 +1,48 @@ | |||
| -- httpserver-connection | |||
There was a problem hiding this comment.
this comment seems outdated...
Why rename the file, though? Can you explain the reasoning behind this?
There was a problem hiding this comment.
ITs not a rename but an alternative implementation of the connection overlay.
I changed sending static files to not use a coroutine as that is quite memory consuming.
So to still be able to use the header.lua I needed a buffer to collect the separate sends in a string and then send them out.
I then only store the filename and the current position to send the chunks of the file.
|
So I will close this PR and create separate ones |
You can define static files as errorhandlers based on errorcode and file extension.
The last commits add support for six cars (or more) without crash. I serve static files without coroutine now. Very memory effichient!
Tested all sample pages successfully.
Also fix and improve many small details: