Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: proper new arch + backwards compat using install function #218

Closed
wants to merge 102 commits into from
Closed

chore: proper new arch + backwards compat using install function #218

wants to merge 102 commits into from

Conversation

hannojg
Copy link
Member

@hannojg hannojg commented Oct 16, 2024 •
edited
Loading

See: https://reactnative.dev/blog/2024/08/12/release-0.75#accessing-jsiruntime-in-turbomodules

  • Updates the example app to be RN 0.75
  • Removes being a Cxx Only turbo module / enables this to be a prefab again on android
  • Works on old arch / new arch

All tests passing on new and old arch

Screenshot_20241016_160635
Screenshot 2024-10-16 at 16 24 16

@mrousavy
feat: Move everything into package/
f8bf6d7
@mrousavy
Update Podfile.lock
a39ab21
@mrousavy
Create .gitignore
efbf23e
@mrousavy
Update .gitignore
23b06b3
@mrousavy
feat: Upgrade Android to new arch C++ only
5d7c8b7
@mrousavy
Create C++ loader
4f48e8f
@mrousavy
fix: Fix configs
eed7c0f
@mrousavy
Update react-native.config.js
2fc4b4e
@mrousavy
Update package.json
c4d3d8a
@mrousavy
Update useRunOnJS.ts
a37b3af
@mrousavy
Update package.json
d2f184b
@mrousavy
Rename
58d75aa
@mrousavy
chore: release 2.0.0-beta.1
6854053
@mrousavy
Export Worklets
84fb2d2
@mrousavy
fix: Update CI paths
25c0c7f
@mrousavy
fix: Fix CI
09eb3bd
@mrousavy
Remove JSC for simplicity
651f4ac
@mrousavy
feat: Upgrade Example app
0bfd8cc
@mrousavy
feat: Create NativeWorkletsModule CXX
1030273
@mrousavy
Format
a40ee2b
@mrousavy
Try to refactor everything away from static singletons....
15552fd
@mrousavy
oh my god
cac72f3
@mrousavy
fix: Fix decorators again
a16079f
@mrousavy
fix: Fix ctx throwing
6201411
@mrousavy
Update WKTJsiWorkletContext.h
f03a4d7
@mrousavy
Update WKTJsiWorklet.h
224887f
@mrousavy
feat: Try to clean up createRunInContext
f042e4f
@mrousavy
feat: Rewrite the whole createCallInContext logic into `FunctionInv…
ada3a53 
…oker`
@mrousavy
fix: Implement createRunOnJS - stub out Promise
30e3d79
@mrousavy
feat: Create FunctionInvoker:: callAndForget
6eebe9c
@mrousavy
Copy link
Member

lgtm!

@mrousavy
Copy link
Member

so can we fix C++ lint and ESLint and tests in a follow up PR?

@hannojg hannojg changed the title Use runtime install function chore: proper new arch + backwards compat using install function Oct 31, 2024
@hannojg hannojg changed the base branch from feat/cxxturbomodule to main October 31, 2024 09:06
@hannojg hannojg mentioned this pull request Oct 31, 2024
Closed
@hannojg
Copy link
Member Author

hannojg commented Nov 6, 2024

Closed in favour of:

@hannojg hannojg closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrousavy mrousavy mrousavy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannojg @mrousavy