Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it a script #14

Merged
merged 8 commits into from
Feb 1, 2024
Merged

Make it a script #14

merged 8 commits into from
Feb 1, 2024

Conversation

ocefpaf
Copy link
Contributor

@ocefpaf ocefpaf commented Feb 1, 2024

Closes #13

The real problem was that, in a fresh env in the CIs, we were hitting conda-forge/tiledb-feedstock#228, but I took this opportunity to:

  • make it a script
  • lock the environment
  • log the errors/warnings in the CIs
  • add dependabot to keep the GitHub Actions updated

@ocefpaf
Copy link
Contributor Author

ocefpaf commented Feb 1, 2024

@MathewBiddle this one is ready for review.

@MathewBiddle
Copy link
Contributor

This looks good to me. I was able to run it locally without issues. Merging.

@MathewBiddle MathewBiddle merged commit 635bf22 into marinebon:main Feb 1, 2024
1 check passed
@ocefpaf ocefpaf deleted the script branch February 2, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action fails to run notebook
2 participants