-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse generator when possible #18
Open
roni-frantchi
wants to merge
38
commits into
marionebl:master
Choose a base branch
from
env0:chore-reuse-generator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: tsconfig compiler options
Switch to ts-json-schema-generator instead
Fix - noTypeCheck => skipTypeCheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building a schema generator (more precisely, building the TypeScript
program
it uses), is very costly.Trials show 5-6s in large projects.
Right now if
JsonSchema.fromType<>()
is usedn
times, this generator (and the TypeScript program that comes with it), will be builtn
times.In most cases, the generator and its program can be reused - shaving off precious build minutes and memory pressure.
The only exception is when
JsonSchema.fromType<>()
is given the optional argument to change the generator config - in this case, a new generator will be built and used instead of the default one.So in most cases, this PR will introduce an optimization making the transformer it
n
times faster.Next optimization steps
Since we're running within a TypeScript program, maybe we'd would be able to reuse the
program
that is being transpiled right now instead of creating a new one.That should shave off those final seconds.