Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change reduce behavior, when empty iterable #236

Merged
merged 1 commit into from
Oct 21, 2023
Merged

feat: change reduce behavior, when empty iterable #236

merged 1 commit into from
Oct 21, 2023

Conversation

ppeeou
Copy link
Member

@ppeeou ppeeou commented Oct 9, 2023

Fixes #235

@ppeeou ppeeou added the enhancement New feature or request label Oct 9, 2023
@ppeeou ppeeou self-assigned this Oct 9, 2023
@ppeeou ppeeou requested a review from shine1594 as a code owner October 9, 2023 11:20
@ppeeou ppeeou requested a review from hg-pyun October 9, 2023 11:21
hg-pyun
hg-pyun approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the code is previously operating as undefined, it can be a breaking change. I think it would be good to mention this in the next release note.

@ppeeou
Copy link
Member Author

ppeeou commented Oct 19, 2023

If the code is previously operating as undefined, it can be a breaking change. I think it would be good to mention this in the next release note.

yes I will

shine1594
shine1594 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@shine1594 shine1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ppeeou ppeeou merged commit 469e7df into main Oct 21, 2023
1 check passed
@ppeeou ppeeou deleted the feat/235 branch October 21, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hg-pyun hg-pyun hg-pyun approved these changes

@shine1594 shine1594 shine1594 approved these changes

Assignees

@ppeeou ppeeou

Labels
enhancement New feature or request HACKTOBERFEST-ACCEPTED
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change reduce behavior, When there are two arguments for reduce, and the first iterator value is done:true
3 participants
@ppeeou @shine1594 @hg-pyun