New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for 32-bit architectures #1

Open

arl wants to merge 1 commit into martin-sucha:main from arl:fix/32-bit

arl commented Dec 6, 2024

On 32-bit platforms, ARM in my case but this is not specific to arm, with go1.23.3, go build fails with:

# github.com/martin-sucha/timezones
vendor/github.com/martin-sucha/timezones/timezones.go:97:29: math.MaxUint32 (untyped int constant 4294967295) overflows int
vendor/github.com/martin-sucha/timezones/timezones.go:98:85: cannot use math.MaxUint32 (untyped int constant 4294967295) as int value in argument to fmt.Errorf (overflows)

This PR simply casts to int64 the integers variables involved with 4294967295 comparisons

And the library works on ARM 32-bit


          Fix for 32-bit architectures

8e1e8ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet