Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dolar tj and converter #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add dolar tj and converter #2

wants to merge 5 commits into from

Conversation

pabloferrari
Copy link

Added dollar TJ quote
image

Converter:

USD to ARS -> dolar :amount
ARS to USD -> dolar :amount --to-usd

image

@martincarrera
Copy link
Owner

Hey @pabloferrari, sorry I didn't see your PR before.

Can you extract the 1.65 to a constant at the top of the file, and verify if that number is still correct?

Thanks for taking the time to add this!

@martincarrera martincarrera self-requested a review October 27, 2022 19:29
@pabloferrari
Copy link
Author

Hey @martincarrera, I just updated the PR.

  • extracted CC conversion rate
  • changes in results and conversion

Screenshot 2022-12-28 at 12 23 14

Screenshot 2022-12-28 at 12 21 59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martincarrera martincarrera Awaiting requested review from martincarrera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pabloferrari @martincarrera