Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SizeandConnectedness updated file post Hlevel -> Truncation #328

Closed

Conversation

IanRay11
Copy link
Contributor

Just want to log my progress so far. Much more to do.

@IanRay11
Copy link
Contributor Author

@tomdjong I've finally finished the formalization of Dan's paper. I need to do some cleaning up and typo checking... Also you will likely wish for me to split into multiple PRs since there are multiple file changes (although ever change was directly motivated by something needed for Dan's paper.) Let me know.

@IanRay11 IanRay11 marked this pull request as ready for review November 20, 2024 01:36
@tomdjong
Copy link
Collaborator

Thanks @IanRay11! Could you:

  1. Split this into two separate PRs: one for the new file and one for everything else (this one should come first).
  2. Give a proper citation to Dan's paper, including the title, year, journal, and its DOI.
  3. Check for unused imports.
  4. Open a PR after you've cleaned up and commented where necessary.

Thank you!
(I will also close this PR.)

@tomdjong tomdjong closed this Nov 20, 2024
@IanRay11
Copy link
Contributor Author

On it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants