jj-lib: abstract a lower-level api for fetching from git. #4959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essiene
force-pushed
the
essiene/nwtzqzumrzyw
branch
from
e5cb616
to
cc6382a
Compare
5 tasks
yuja
reviewed
Nov 24, 2024
yuja
reviewed
Nov 24, 2024
essiene
force-pushed
the
essiene/nwtzqzumrzyw
branch
from
cc6382a
to
35554c0
Compare
essiene
force-pushed
the
essiene/nwtzqzumrzyw
branch
2 times, most recently
from
c35a6f7
to
c2e4cb0
Compare
yuja
approved these changes
Dec 1, 2024
essiene
force-pushed
the
essiene/nwtzqzumrzyw
branch
4 times, most recently
from
ed6876d
to
d5c1a07
Compare
* GitFetch{} separates `fetch()` from `import_refs()`.
* This allows more control over the stages of the fetch so multiple fetches
can happen before `import_refs` resolves the changes in the local jj repo.
* Implement `git::fetch` in terms of the new api.
* Add a test case for initial fetch from a repo without `HEAD` set. This tests
the default branch retrieving behaviour.
Issue: #4923
essiene
force-pushed
the
essiene/nwtzqzumrzyw
branch
from
d5c1a07
to
5275f9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetch()fromimport_refs().can happen before
import_refsresolves the changes in the local jj repo.git::fetchin terms of the new api.HEADset. This teststhe default branch retrieving behaviour.
Issue: #4923
Checklist
If applicable: