-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix listener in hooks #70
base: master
Are you sure you want to change the base?
Conversation
Solved Issues #69. |
I think using a callback for the so consider something like. `
};` Lesser code and solves the problem for functional and class based components. Try refactoring your code, and make changes only to the lines that concerns your PR. |
@Cmion |
I also looks like the library needs some maintenance too |
@Cmion It was a change of the format code ... |
Some quick, hopefully constructive, feedback on this PR:
Thank you for your efforts on this! Really, really appreciated. |
Encapsulate the changes inspired by marudy#70
Solved Issues #69.
Please merge