This repository has been archived by the owner on Jun 26, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
DP-4176 Service page documentation #521
Merged
Merged
Changes from 190 commits
Commits
Show all changes
191 commits
Select commit
Hold shift + click to select a range
019005e
Add shell script to deploy PL build to gh-pages branch of given repo
jesconstantine 7e08d04
Make deploy script executable
jesconstantine fb62369
Use bash shebang in deploy script
jesconstantine ffc83a1
Fix conditional logic
jesconstantine 41cbd1c
Write git output to screen
jesconstantine 5576165
Fix conditional logic check for false
jesconstantine 5252623
print variable name in log
jesconstantine 2199e94
update order of args
jesconstantine 5155a97
Fix conditional logic boolean false
jesconstantine ffbf270
fix variable assignment, remove spaces
jesconstantine a332c9e
echo errors in red, success in green
jesconstantine aa388a8
fix validation of target environment
jesconstantine aacc49d
Update deploy script argument validation
jesconstantine bc04ffa
Validate git push during deploy
jesconstantine 010273a
Exit deploy script on failed build
jesconstantine e27dd2d
Update docs
jesconstantine 1812d9d
Fix syntax error.
jesconstantine 5321706
Create a function for cleanup
jesconstantine 22578ed
Fix target URL
jesconstantine 7c8c04e
Create function for success / error logging
jesconstantine 89a2ef7
Update docs
jesconstantine ad648ef
Ensure that patterns are blown away before built
jesconstantine 330c301
Remove exit on error log
jesconstantine a6b8eea
Fix string comparison in log function
jesconstantine 2757e2c
Add final error message to deploy script
jesconstantine c31de50
Make wrong target remote repo message more helpful
jesconstantine 4934d9a
Create CNAME for staging (test)
jesconstantine 2db7592
Test confirm functionality
jesconstantine d2d1f39
Create CNAME for stage / prod
jesconstantine 4dcb5bb
Add logic for final success message non/prod
jesconstantine 31b4872
Update readme with deploy, contrib, versions, license info
jesconstantine e29f591
Create contributing documentation
jesconstantine bc8beca
Create deploy documentation
jesconstantine 9287cb4
Fix readme link typo
jesconstantine 68f1f44
Fix link to contributing.md
jesconstantine f1c9aa9
Update github pages settings docs
jesconstantine f3e8818
Update Contributing md with Mayflower, PR tips.
jesconstantine c1b2864
Create PR template
jesconstantine ccf17c0
Create issue template
jesconstantine d6323d5
Fix typo and make contributing language more friendly
jesconstantine d6d9ff5
Update steps to browse in readme.
jesconstantine 6b9c7fd
Update readme browse Mayflower steps
jesconstantine 830aab5
Fix readme typo.
jesconstantine d0afcfa
Add deployment steps to contributing.md
jesconstantine c0f8dc6
Fix typo, styling of deploy docs.
jesconstantine 355ee8f
Add PHP version to readme.
jesconstantine 63d4393
Update built with pattern lab language in readme
jesconstantine e480243
Update mayflower artifacts text in readme.
jesconstantine 697a8ae
Add git commit context to contributing docs
jesconstantine 51335a1
Format readme
jesconstantine 47df5cb
Describe project file structure in contributing.md
jesconstantine 715bb99
Format contributing.md
jesconstantine 90c1124
Clarify github pull request buttons in contributing md
jesconstantine dd9038a
Remove acknowledgements from contributing TOC
jesconstantine eedad80
Format prerequisite in deploy docs
jesconstantine 4066e7e
Link to gulp readme from deploy docs
jesconstantine 98718d7
Log output when production deploy aborted
jesconstantine 8e3b38a
Merge branch 'manual-deploy' into DP-4053-document-manual-deploy-process
jesconstantine e3192f3
Use main repo as example in deploy script comments
jesconstantine 5ad608e
Make cname a parameter for deploy script, required for prod only
jesconstantine 204b093
Move CONTRIBUTING.md into .github directory
jesconstantine 6a6263b
Remove written descriptions of Github's UI, replace with link to docs
jesconstantine 8662b1f
Make CONTRIBUTING.md branching language more consistent with git
jesconstantine c667e7f
Move pattern lab docs to first step in CONTRIBUTING > working with PL
jesconstantine 56f7c30
Remove vague language in CONTRIBUTING.md
jesconstantine 5fa898a
Clarify Mayflower Artifacts in readme
jesconstantine 232296f
Make CONTRIBUTING.md > keeping your fork in sync explanation more clear.
jesconstantine 700b3b7
Move environment setup and demo install instructions to own docs
jesconstantine c77e3cc
Group steps in CONTRIBUTING.md
jesconstantine 0a1664a
Fix link to CONTRIBUTING.md after move to /.github
jesconstantine ad16e9c
Simplify readme install / contribute / deploy sections
jesconstantine 17c18f3
Remove link to personal fork, but keep repo name, in deploy docs
jesconstantine 8015c8e
Fix mayflower-artifacts url in readme
jesconstantine 8edde43
Update the deploy success message to use cname if present
jesconstantine e0f7206
Fix cname conditional logic in deploy script.
jesconstantine 31957c7
Use [-c] rather tha [-cname] as parameter for gh pages deploy script
jesconstantine 5c713e5
Fix typo in success message for cname
jesconstantine 06aeea9
Fix deploy script config for url.domain/assetsPath when cname passed
jesconstantine b06e445
Improve script logging: hide lengthy status/success, color + tag logs.
jesconstantine 6f5ab99
Fix typos.
jesconstantine e6c68ed
Fix typo in docs for [-t] argument.
jesconstantine 031b2bc
Move log prior to command for creating cname in deploy script.
jesconstantine cfd5087
Avoid having to escape / in deploy script > assetsPath var
jesconstantine f0db750
Allow assetsPath to be passed with cname flag
jesconstantine f3e6dd7
Accept [-a] argument in deploy script
jesconstantine 1011eb3
Fix deploy script [-t] flag to be target remote repo *owner*
jesconstantine 34e5e46
Remove extra " from assetsPath in url.json
jesconstantine 58beead
Update [-c] validation log to reflect [-c] vs [-cname]
jesconstantine 72ade22
Add developer deploy docs note about cname and assetPaths flags.
jesconstantine 355c572
Uncomment script. So. It. Does. Things. (silly)
jesconstantine cef2d8b
Link to mayflower artifacts docs from readme (vs duplicating content)
jesconstantine 348c13a
DP-4048 - Annotations - updating to look for JS classes used.
4c7c21b
DP-4048 - Annotations - The extra html added breaks the styles
593d82b
Dp-4048 - Extra Js - removing unused JS files
842c6b8
DP-4048 - updating Styling of Pattern Info panel
b29c177
DP-4048 - Contact List - Documentation
51903e8
DP-4048 - Image
f508b57
DP-4048 - Pattern Documentation - Remving Usage Guidelines.
d9b7300
DP-4048 - additional tweaks to md files
3f539d5
DP-4048 - Lineage styling
fb8b7a8
DP-4048 - Removing title yaml.
96f34ba
Make all intra-docs links relative
jesconstantine c042dd5
Fix deploy docs links
jesconstantine 4d7c86d
Update clone steps to be more clear
jesconstantine 29c26e7
Ensure branch is clean after deploy, fix typos
jesconstantine abda85f
Add patternlab task to deafult gulp ( = always generate patterns)
jesconstantine ca4388e
Try gulp prod in deploy script
jesconstantine 243f6d6
Ensure public directory gets cleaned out prior to generation
jesconstantine a32f1fa
DP-4048 - Contact List - removed 'title' field from docs
7fd162e
DP-4176 - Service Page and Template - documentation
95c4718
DP-4053 - Introduce & document a manual deployment process
bc00f70
DP-4176 - Page Banner - Documentation
c16a4f8
Merge branch 'DP-4048-PatternDocs' into DP-4176-ServicePageDocs
0b14948
DP-4048 Establish format for pattern docs (#515)
8e00148
DP-4176 - Image - documentation
dc368dc
DP-4176 - Video - documentation
d4fdd8c
DP-4176 - Documentation template
aacbec8
DP-4176 - Key Actions - Documentation
d502a2a
DP-4176 - Decorative Link - documentation
b14b397
DP-4176 - Key Actions - adding contained type
7188b15
DP-4167 - Callout Link - documentation
fc1ef06
DP-4176 - Illustrated link - documentation
88c9f3a
DP-4176 - Variant Documentation template
c4153c0
DP-4176 - Contact List - Updated variant documentation
62df2ad
DP-4176 - Sidebar Heading - documentation
777bdc8
DP-4176 - Comp Heading - documentation
11a653f
DP-4176 - Variants - making link relative './'
9c9fcc9
DP-4176 - Icon Links - documentation
6232107
DP-4176 - Link List - documentation
0491c0d
DP-4176 - Link List - documention of Right Rail usage
b5f0c0c
DP-4176 - Action Finder - documentation
605e552
DP-4176 - Mapped Locations - documentation
52a2333
DP-4176 - Variant template updated
93a7197
DP-4176 - Mapped Locations - Removed title from contained version
4014afd
DP-4176 - Callout Link External - removed variant
2eaedcc
Mapped Locations - Fixing bug with assigning the colored background
0f9eb44
DP-4176 - Split Columns - documentation
7c32634
DP-4176 - Rich Text - documentation
eca96ed
DP-4176 - Download Link - documentation
830110c
DP-4176 - Forms Downloads - documentation
d0b777f
DP-4176 - Utility Panel - documentation
d764475
DP-4176 - Utility Nav - documentation
5b11ef6
DP-4176 - Header - documentation
9530661
DP-4176 - Button Search - documentation
f125c5b
DP-4176 - Site Logo - documentation
d89380a
DP-4176 - Header Search - documentation
65d480d
DP-4176 - Main Nav - documentation
42b931a
DP-4176 - Button - documentation
c9a805f
DP-4176 - Button - adding link option and correcting styling classes
7d7d621
DP-4176 - Button Link - marking it as depreciated
04492cc
DP-4176 - Floating Action - updated to use just the button atom
b5e1b33
DP-4176 - Floating Action - documentation
1b8b99d
DP-4176 - Buttons - Updates to SCSS selectors
1cc4d8b
DP-4176 - Floating Action - correcting styling classes
58eed5c
DP-4176 - Footer - documentation
6aff0fb
DP-4176 - Heading / Util Panel - marking as in Progress so we can update
5a46115
DP-4176 - Button - re-adding support for the 'theme' variable
e0cb1e5
DP-4176 - Social Links - documentation
f508347
DP-4176 - Footer Links - documentation
cf3741b
Merge branch 'C4-Documentation' into DP-4176-ServicePageDocs
df0a2d0
DP-4176 - Buttons - leaving old styles for backward compatibilty
ce4c461
DP-4167 - Callout Link - moving the info variable to a title attribute
5403625
DP-4176 - Buttons - incorrect indentation
3639b3c
DP-4167 - Rich Text - updating to include all accepted patterns
106f2b6
DP-4176 - Rich text sub patterns - documentation
71f7096
DP-4167 - figure - documentation and modified to use --left/--right c…
e4742b1
DP-4167 - Table - documentation
4ebb61f
DP-4080 - Versioning Documentation (#504)
b3eab14
Merge branch 'C4-Documentation' into DP-4176-ServicePageDocs
49df990
Merge remote-tracking branch 'origin/C4-Docs' into DP-4176-ServicePag…
39c93d3
DP-4176 - Callout Link - making CSS backward compatible
c730918
DP-4176 - Floating Action - making code backward compatible
c38094f
DP-4177 - Button - fixed logic to use old "theme" variable for color.
c385a23
DP-4178 - Button - fixing broken links
1fe9c27
DP-4176 - Button - switching color back to theme include values
3ee70c6
DP-4176 - Comp Heading - correcting id value
cf02035
DP-4176 - Decorative Link - removing schema.org and using title
b532c65
DP-4176 - Linked List - Update docs
baac8de
DP-4176 - Mapped Locations - updated docs
ef3a1a0
DP-4176 - Page Banner - Updated Docs
5ea0b24
DP-4176 - Services Template - updated docs
bb73be8
DP-4176 - Action Finder - updated docs
e485671
DP-4176 - Download Link - removing property
1117e5e
DP-4176 - Callout Link - Better descriptive text
05bcc1d
DP-4176 - Video - updated documentation
2b055fb
DP-4176 - Decorative Link - updated docs
1cefde3
DP-4176 - Mapped Locations - adding more useage guidelines
9e7ac8d
Merge branch 'C4-Docs' into DP-4176-ServicePageDocs
1927def
DP-4176 - Button - updated docs
6040180
DP-4176 - Table - updated docs
30362b4
DP-4176 - Comp Heading - changing id value
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
styleguide/source/_patterns/01-atoms/01-buttons/button-as-link.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
### Description | ||
This is a variant of the [Button](./?p=atoms-button) pattern showing an example using a link instead of a button. | ||
|
||
### How to generate | ||
* Populate the 'href' variable |
5 changes: 5 additions & 0 deletions
5
styleguide/source/_patterns/01-atoms/01-buttons/button-as-outline.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
### Description | ||
This is a variant of the [Button](./?p=atoms-button) pattern showing an example styled as an outline. | ||
|
||
### How to generate | ||
* set the 'outline' variable to true |
5 changes: 5 additions & 0 deletions
5
styleguide/source/_patterns/01-atoms/01-buttons/button-as-quaternary-color.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
### Description | ||
This is a variant of the [Button](./?p=atoms-button) pattern showing an example in gray. | ||
|
||
### How to generate | ||
* set the 'theme' variable to 'quaternary' |
7 changes: 7 additions & 0 deletions
7
styleguide/source/_patterns/01-atoms/01-buttons/button-as-secondary-color.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
### Description | ||
This is a variant of the [Button](./?p=atoms-button) pattern showing a small button example in green with an outline. | ||
|
||
### How to generate | ||
* set the 'theme' variable to 'secondary' | ||
* set the 'outline' variable to true | ||
* set the 'size' variable to 'small' |
5 changes: 5 additions & 0 deletions
5
styleguide/source/_patterns/01-atoms/01-buttons/button-as-small.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
### Description | ||
This is a variant of the [Button](./?p=atoms-button) pattern showing an example of a small button. | ||
|
||
### How to generate | ||
* set the 'size' variable to 'small' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 8 additions & 17 deletions
25
styleguide/source/_patterns/01-atoms/01-buttons/button-search.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,13 @@ | ||
--- | ||
title: Button Search | ||
--- | ||
Description: A `<button> [type='submit']` element which contains a visually hidden `<span>` element and an `<svg>` icon element. | ||
### Description | ||
A Button used for keyword search. | ||
|
||
## State: ALPHA | ||
### Used In: | ||
- [@molecules/header-search](/?p=molecules-header-search) | ||
- [@molecules/keyword-search](/?p=molecules-keyword-search) | ||
### Status | ||
* Stable as of 5.0.0 | ||
|
||
### Contains: | ||
- [@atoms/05-icons/svg-search.twig](/?p=atoms-svg-search) | ||
|
||
### Required Variables: | ||
### Variables | ||
~~~ | ||
buttonSearch { | ||
text: | ||
type: string/required | ||
buttonSearch: { | ||
text: | ||
type: string / required | ||
} | ||
~~~ | ||
|
||
~~~ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
{ | ||
"button": { | ||
"href": "", | ||
"info": "", | ||
"text": "Button", | ||
"type": "button", | ||
"size": "", | ||
|
28 changes: 17 additions & 11 deletions
28
styleguide/source/_patterns/01-atoms/01-buttons/button.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 13 additions & 9 deletions
22
styleguide/source/_patterns/01-atoms/01-buttons/button.twig
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,16 @@ | ||
{% set buttonClassSize = button.size ? "ma__button--" ~ button.size : "" %} | ||
{% set buttonClass = "ma__button" %} | ||
{% set buttonSize = button.size ? "ma__button--" ~ button.size : "" %} | ||
|
||
{% if button.outline %} | ||
{% set buttonClass = buttonClass ~ "-minor" %} | ||
{% endif %} | ||
{% set buttonStyle = button.outline ? "ma__button--minor" : "" %} | ||
|
||
{% if button.theme %} | ||
{% set buttonClass = buttonClass ~ "-" ~ button.theme %} | ||
{% endif %} | ||
{% set buttonTheme = button.theme ? "ma__button--" ~ button.theme : "" %} | ||
|
||
<button type="{{ button.type }}" class="{{ buttonClass }} {{ buttonClassSize }}">{{ button.text }}</button> | ||
{% if button.href %} | ||
<a | ||
href="{{ button.href }}" | ||
class="ma__button {{ buttonSize }} {{buttonTheme}} {{buttonStyle}}" | ||
title="{{ button.info }}"> | ||
{{ button.text }} | ||
</a> | ||
{% else %} | ||
<button type="{{ button.type }}" class="ma__button {{ buttonSize }} {{buttonTheme}} {{buttonStyle}}" aria-label="{{ button.info }}">{{ button.text }}</button> | ||
{% endif %} |
11 changes: 11 additions & 0 deletions
11
styleguide/source/_patterns/01-atoms/01-buttons/button~as-link.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"button": { | ||
"href": "#", | ||
"info": "", | ||
"text": "Button", | ||
"type": "", | ||
"size": "", | ||
"theme": "", | ||
"outline": false | ||
} | ||
} |
2 changes: 2 additions & 0 deletions
2
...s/01-atoms/01-buttons/button~outline.json → ...1-atoms/01-buttons/button~as-outline.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
{ | ||
"button": { | ||
"href": "", | ||
"info": "", | ||
"text": "Button", | ||
"type": "button", | ||
"size": "", | ||
|
4 changes: 3 additions & 1 deletion
4
...terns/01-atoms/01-buttons/button~alt.json → ...1-buttons/button~as-quaternary-color.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,11 @@ | ||
{ | ||
"button": { | ||
"href": "", | ||
"info": "", | ||
"text": "Button", | ||
"type": "button", | ||
"size": "", | ||
"theme": "alt", | ||
"theme": "quaternary", | ||
"outline": false | ||
} | ||
} |
11 changes: 11 additions & 0 deletions
11
styleguide/source/_patterns/01-atoms/01-buttons/button~as-secondary-color.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"button": { | ||
"href": "", | ||
"info": "", | ||
"text": "Button", | ||
"type": "button", | ||
"size": "small", | ||
"theme": "secondary", | ||
"outline": true | ||
} | ||
} |
2 changes: 2 additions & 0 deletions
2
...rns/01-atoms/01-buttons/button~small.json → .../01-atoms/01-buttons/button~as-small.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
{ | ||
"button": { | ||
"href": "", | ||
"info": "", | ||
"text": "Button", | ||
"type": "button", | ||
"size": "small", | ||
|
13 changes: 4 additions & 9 deletions
13
styleguide/source/_patterns/01-atoms/04-headings/comp-heading-centered.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,5 @@ | ||
--- | ||
title: Comp Heading Centered | ||
--- | ||
Description: Centered Variant of Comp Heading. | ||
### Description | ||
This is a variant of the [Comp Heading](./?p=atoms-comp-heading) showing an example with a centered underline. | ||
|
||
### Notes | ||
- _centered variable is set to 'true'_ | ||
|
||
### Base | ||
- [@atoms/04-headings/comp-heading](/?p=atoms-comp-heading) | ||
### How to generate | ||
* Set the 'centered' variable equal to boolean value true |
13 changes: 4 additions & 9 deletions
13
styleguide/source/_patterns/01-atoms/04-headings/comp-heading-subheading.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,5 @@ | ||
--- | ||
title: Comp Subheading | ||
--- | ||
Description: Subheading Variant of Comp Heading. | ||
### Description | ||
This is a variant of the [Comp Heading](./?p=atoms-comp-heading) showing an example as a sub heading (H3). | ||
|
||
### Notes | ||
- _sub variable is set to 'true'_ | ||
|
||
### Base | ||
- [@atoms/04-headings/comp-heading](/?p=atoms-comp-heading) | ||
### How to generate | ||
* Set the 'sub' variable equal to the boolean value true |
13 changes: 4 additions & 9 deletions
13
styleguide/source/_patterns/01-atoms/04-headings/comp-heading-yellow.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,5 @@ | ||
--- | ||
title: Comp Heading Yellow | ||
--- | ||
Description: Yellow Variant of Comp Heading. | ||
### Description | ||
This is a variant of the [Comp Heading](./?p=atoms-comp-heading) showing an example with a yellow underline. | ||
|
||
### Notes: | ||
- _color variable is set to 'yellow'_ | ||
|
||
### Base | ||
- [@atoms/04-headings/comp-heading](/?p=atoms-comp-heading) | ||
### How to generate | ||
* Set the 'color' variable equal to "yellow" |
4 changes: 2 additions & 2 deletions
4
styleguide/source/_patterns/01-atoms/04-headings/comp-heading.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
{ | ||
"compHeading": { | ||
"title": "Employment", | ||
"title": "Title text", | ||
"sub": "", | ||
"color": "", | ||
"id": "employment", | ||
"id": "title-text", | ||
"centered": "" | ||
} | ||
} |
36 changes: 12 additions & 24 deletions
36
styleguide/source/_patterns/01-atoms/04-headings/comp-heading.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,38 +1,26 @@ | ||
--- | ||
title: Comp Heading | ||
--- | ||
Description: An `<h2>` or `<h3>` element with a styled underline color designated by its CSS class. | ||
### Description | ||
An `<h2>` element with a styled underline color | ||
|
||
## State: ALPHA | ||
### Status | ||
* Stable as of 5.0.0 | ||
|
||
### Notes: | ||
### Variant options | ||
* [Sub Heading](./?p=atoms-comp-heading-subheading) by setting 'sub' to true. | ||
* [Centered](./?p=atoms-comp-heading-centered) by setting 'centered' to true | ||
* [Yelllow Underline](./?p=atoms-comp-heading-yellow) by setting 'color' to "yellow" | ||
|
||
|
||
### Used In: | ||
- [@molecules/action-section](/?p=molecules-action-section) | ||
- [@organisms/by-author/key-actions](/?p=organisms-key-actions) | ||
- [@organisms/by-author/helpful-links](/?p=organisms-helpful-links) | ||
- [@organisms/by-author/form-download](/?p=organisms-form-download) | ||
- [@organisms/by-author/multi-row-section](/?p=organisms-multi-row-section) | ||
|
||
### Variables: | ||
### Variables | ||
~~~ | ||
compHeading: { | ||
title: | ||
type: string / required | ||
sub: | ||
type: string ("true" || "" ) | ||
type: string ("true" || "" ) / optional | ||
color: | ||
type: string ("yellow") | ||
type: string ("yellow") / optional | ||
id: | ||
type: string | ||
type: string (unique per page) / optional | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unique per page - 👍 |
||
centered: | ||
type: boolean | ||
} | ||
~~~ | ||
|
||
### Variations | ||
- [@atoms/04-headings/comp-heading](/?p=atoms-comp-heading) | ||
- [@atoms/04-headings/comp-heading-subheading](/?p=atoms-comp-heading-subheading) | ||
- [@atoms/04-headings/comp-heading-yellow](/?p=atoms-comp-heading-yellow) | ||
- [@atoms/04-headings/comp-heading-centered](/?p=atoms-comp-heading-centered) |
4 changes: 2 additions & 2 deletions
4
styleguide/source/_patterns/01-atoms/04-headings/comp-heading~centered.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
{ | ||
"compHeading": { | ||
"title": "Employment", | ||
"title": "Title text", | ||
"sub": "", | ||
"color": "", | ||
"id": "employment", | ||
"id": "", | ||
"centered": "true" | ||
} | ||
} |
4 changes: 2 additions & 2 deletions
4
styleguide/source/_patterns/01-atoms/04-headings/comp-heading~subheading.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
{ | ||
"compHeading": { | ||
"title": "Key Actions", | ||
"title": "Title text", | ||
"sub": true, | ||
"color": "", | ||
"id": "key-actions", | ||
"id": "", | ||
"centered": "" | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious as to the motivation behind using the title attribute here vs a visually hidden span?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Title is designed for this purpose so why not use it over doing a hack with a hidden span tag. Also using the attribute allows you to pass a string that doesn't have to be an extension of the button's text.
"view more" + "about this thing" can instead be "click here to read more about this thing"