Solution:1.0 #2

cth-usq · 2024-04-27T13:57:44Z

No description provided.

YuriiSmolii

In general good job, bold and deep parametrization on first review iteration.
Still needs polishing and fixing some minor issues described via comments.

YuriiSmolii · 2024-04-29T21:03:29Z

.infrastructure/helm-chart/todoapp/Chart.yaml

+# A chart can be either an 'application' or a 'library' chart.
+#
+# Application charts are a collection of templates that can be packaged into versioned archives
+# to be deployed.
+#
+# Library charts provide useful utilities or functions for the chart developer. They're included as
+# a dependency of application charts to inject those utilities and functions into the rendering
+# pipeline. Library charts do not define any templates and therefore cannot be deployed.
+type: application
+
+# This is the chart version. This version number should be incremented each time you make changes
+# to the chart and its templates, including the app version.
+# Versions are expected to follow Semantic Versioning (https://semver.org/)
+version: 0.1.0
+
+# This is the version number of the application being deployed. This version number should be
+# incremented each time you make changes to the application. Versions are not expected to
+# follow Semantic Versioning. They should reflect the version the application is using.
+# It is recommended to use it with quotes.


Remove generated comments, they make configs look messy.

YuriiSmolii · 2024-04-29T21:05:57Z

.infrastructure/helm-chart/todoapp/values.yaml

+      averageUtilization: 70
+
+  secret:
+    SECRET_KEY: QGUyKHl4KXYmdGdoM19zPTB5amEtaSFkcGVieHN6XmRnNDd4KS1rJmtxXzN6Zio5ZSoK(@e2(yx)v&tgh3_s=0yja-i!dpebxsz^dg47x)-k&kq_3zf*9e*)


Do not store secret value as a plain text in values.yml

I have a question to this part.
In video "Creating Helm Chart - Working with values files" (27 sec), mentor implemented it in exect way.
Could you say how it must be implemented? I need to use values in b64?

Or create a 3rd file with secretKeyRef on secret.yml. and that values copy to values.yaml, after paste to deployment.yml?

@cth-usq good question. I will repeat this question to course creators.

@YuriiSmolii here is example of second variant (https://ververica.zendesk.com/hc/en-us/articles/360015021359-How-to-secure-passwords-secrets-in-values-yaml-with-Kubernetes-secrets)

YuriiSmolii · 2024-04-29T21:05:58Z

.infrastructure/helm-chart/todoapp/values.yaml

+    DB_USER: "app_user"
+    DB_PASSWORD: "1234"


Do not store secret value as a plain text in values.yml

YuriiSmolii · 2024-04-29T21:07:22Z

.infrastructure/helm-chart/todoapp/values.yaml

Secrets wrongly configured and no configs for ServiceAccount

YuriiSmolii · 2024-04-29T21:10:15Z

.infrastructure/helm-chart/todoapp/values.yaml

@@ -0,0 +1,51 @@
+common:
+ namespace: todoapp


Namespace is not common for subchart

YuriiSmolii · 2024-04-29T21:11:22Z

.infrastructure/helm-chart/todoapp/charts/mysql/values.yaml

+    MYSQL_ROOT_PASSWORD: 1234
+    MYSQL_USER: app_user
+    MYSQL_PASSWORD: 1234


Same with secrets here.

YuriiSmolii · 2024-04-29T21:12:02Z

.infrastructure/helm-chart/todoapp/charts/mysql/Chart.yaml

+# A chart can be either an 'application' or a 'library' chart.
+#
+# Application charts are a collection of templates that can be packaged into versioned archives
+# to be deployed.
+#
+# Library charts provide useful utilities or functions for the chart developer. They're included as
+# a dependency of application charts to inject those utilities and functions into the rendering
+# pipeline. Library charts do not define any templates and therefore cannot be deployed.
+type: application
+
+# This is the chart version. This version number should be incremented each time you make changes
+# to the chart and its templates, including the app version.
+# Versions are expected to follow Semantic Versioning (https://semver.org/)
+version: 0.1.0
+
+# This is the version number of the application being deployed. This version number should be
+# incremented each time you make changes to the application. Versions are not expected to
+# follow Semantic Versioning. They should reflect the version the application is using.
+# It is recommended to use it with quotes.


Remove generated text here as well.

YuriiSmolii · 2024-04-29T21:15:15Z

.infrastructure/helm-chart/todoapp/charts/mysql/templates/service.yml

+# pod-name.service-name.namespace.svc.cluster.local
+# pod-name.service-name
+# mysql-0.mysql.mysql.svc.cluster.local


Remove commented code.

YuriiSmolii · 2024-04-29T21:15:59Z

.infrastructure/helm-chart/todoapp/charts/mysql/templates/statefulSet.yml

+          requests:
+            cpu: {{ .Values.mysql.statefulSet.resources.requests.cpu }}
+            memory: {{ .Values.mysql.statefulSet.resources.requests.memory }}
+        livenessProbe:


You could import the whole block from values. And same for other below

YuriiSmolii

Minor changes requested.
Щодо secrets, на цьому етапі зараховуємо завдання з секретами у values.yml, як це. було показано на відео.

YuriiSmolii · 2024-05-01T09:58:12Z

.infrastructure/helm-chart/todoapp/charts/mysql/templates/configMap.yml

+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: {{ .Chart.Name }}


Use chart name as prefix, not a full name:

{{ .Chart.Name }}-configmap

YuriiSmolii · 2024-05-01T09:59:10Z

.infrastructure/helm-chart/todoapp/charts/mysql/templates/service.yml

+apiVersion: v1
+kind: Service
+metadata:
+  name: {{ .Chart.Name }}


Suggested change

name: {{ .Chart.Name }}

name: {{ .Chart.Name }}-clusterip

YuriiSmolii · 2024-05-01T10:00:18Z

.infrastructure/helm-chart/todoapp/charts/mysql/templates/statefulSet.yml

+apiVersion: apps/v1
+kind: StatefulSet
+metadata:
+  name: {{ .Chart.Name }}


Suggested change

name: {{ .Chart.Name }}

name: {{ .Chart.Name }}-statefulset

YuriiSmolii · 2024-05-01T10:01:26Z

.infrastructure/helm-chart/todoapp/charts/mysql/templates/statefulSet.yml

+          requests:
+            {{ .Values.mysql.statefulSet.resources.requests }}
+        livenessProbe:
+          {{ .Values.mysql.statefulSet.livenessProbe }}
+        readinessProbe:
+          {{ .Values.mysql.statefulSet.readinessProbe }}


This is not changed.

You mean I need to unite resources, levenessProbe and readinesP - and import by one link?

because I made changes from previous commit

Actually, resources, livenessProbe and readinesS on the same level in code line maybe will be better to keep them as 3 lines

YuriiSmolii · 2024-05-01T10:02:00Z

.infrastructure/helm-chart/todoapp/templates/deployment.yml

+        resources:
+          requests:
+            memory: {{ .Values.todoapp.resources.requests.memory | quote }}
+            cpu: {{ .Values.todoapp.resources.requests.cpu | quote }}
+          limits:
+            memory: {{ .Values.todoapp.resources.limits.memory | quote }}
+            cpu: {{ .Values.todoapp.resources.limits.cpu | quote }}


Could be imported whole block.

YuriiSmolii · 2024-05-01T10:02:43Z

bootstrap.sh

Delete commented lines.

cth-usq · 2024-05-01T10:19:00Z

Minor changes requested. Щодо secrets, на цьому етапі зараховуємо завдання з секретами у values.yml, як це. було показано на відео.

@YuriiSmolii Тобто так як я зробив відразу?

YuriiSmolii · 2024-05-01T14:20:43Z

Minor changes requested. Щодо secrets, на цьому етапі зараховуємо завдання з секретами у values.yml, як це. було показано на відео.

@YuriiSmolii Тобто так як я зробив відразу?

Так

YuriiSmolii

Minor change requested.

YuriiSmolii · 2024-05-01T14:21:53Z

.infrastructure/helm-chart/todoapp/templates/deployment.yml

-          limits:
-            memory: {{ .Values.todoapp.resources.limits.memory | quote }}
-            cpu: {{ .Values.todoapp.resources.limits.cpu | quote }}
+          {{ .Values.todoapp.resources.requests.memory }}


Тут неправильно імпортований блок, потрібно не лише memory, а весь блок resource конфігурацій.

Приклад:

spec: containers: - name: my-container image: my-image:latest resources: {{ toYaml .Values.resources | nindent 12 }}

@YuriiSmolii my inattention

YuriiSmolii

Fix lint error below and use "verify --debug" command to double-check solution.

cth-usq · 2024-05-02T13:05:10Z

Fix lint error below and use "verify --debug" command to double-check solution.

Looks like fixed

YuriiSmolii

Все ще багато помилок, ось як виправити:

Дана команда повинна проходити успішно:
helm template . --validate --debug

YuriiSmolii

Виправлено неправильно, команда, яку я вказав у попередній перевірці
успішно не проходить

cth-usq · 2024-05-09T10:44:26Z

@YuriiSmolii

helm template . --validate --debug та helm lint- роходять успішно

YuriiSmolii

Рухаємось далі.

Все ж так як було сказано на QnA секрети стфорються з неправильним ключем-значенням.
Потрібно ще виправити кілька помилок щоб успішно задеплоїти чарт наступною командою : helm install todoapp .

cth-usq · 2024-05-15T10:54:04Z

Рухаємось далі.

Все ж так як було сказано на QnA секрети стфорються з неправильним ключем-значенням.

Потрібно ще виправити кілька помилок щоб успішно задеплоїти чарт наступною командою : helm install todoapp .

@YuriiSmolii

Все виправив Helm запускається

YuriiSmolii

Good job!

Solution

00bbe6e

YuriiSmolii suggested changes Apr 29, 2024

View reviewed changes

Solution:1.1

e408d60

cth-usq force-pushed the develop branch from 74e1303 to e408d60 Compare April 30, 2024 11:34

cth-usq requested a review from YuriiSmolii April 30, 2024 11:36

YuriiSmolii suggested changes May 1, 2024

View reviewed changes

Solution:1.2

00f32a2

cth-usq requested a review from YuriiSmolii May 1, 2024 10:47

YuriiSmolii suggested changes May 1, 2024

View reviewed changes

Solution:1.3

9bee561

cth-usq requested a review from YuriiSmolii May 1, 2024 14:31

YuriiSmolii suggested changes May 1, 2024

View reviewed changes

Solution:1.4

c584c8a

cth-usq requested a review from YuriiSmolii May 2, 2024 13:05

YuriiSmolii suggested changes May 3, 2024

View reviewed changes

cth-usq requested a review from YuriiSmolii May 3, 2024 13:19

YuriiSmolii suggested changes May 3, 2024

View reviewed changes

Solution:3.0

d4d3f34

cth-usq force-pushed the develop branch from ea7034b to d4d3f34 Compare May 9, 2024 10:38

cth-usq requested a review from YuriiSmolii May 9, 2024 10:39

YuriiSmolii suggested changes May 9, 2024

View reviewed changes

Solution:4.0

c2bb6bc

cth-usq requested a review from YuriiSmolii May 15, 2024 10:52

cth-usq added 2 commits May 15, 2024 19:05

add output.log

120495f

output

5e13a1f

output.log with changes in gitignore

3268fdb

YuriiSmolii approved these changes May 15, 2024

View reviewed changes

LevAndrii added a commit to LevAndrii/devops_todolist_kubernetes_task_12_helm_charts that referenced this pull request Dec 17, 2024

Solution mate-academy#2

95ee3ea

Solution:1.0 #2

Are you sure you want to change the base?

Solution:1.0 #2

Conversation

cth-usq commented Apr 27, 2024

YuriiSmolii left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YuriiSmolii left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cth-usq May 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cth-usq commented May 1, 2024

YuriiSmolii commented May 1, 2024

YuriiSmolii left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YuriiSmolii left a comment

Choose a reason for hiding this comment

cth-usq commented May 2, 2024

YuriiSmolii left a comment

Choose a reason for hiding this comment

YuriiSmolii left a comment

Choose a reason for hiding this comment

cth-usq commented May 9, 2024

YuriiSmolii left a comment

Choose a reason for hiding this comment

cth-usq commented May 15, 2024

YuriiSmolii left a comment

Choose a reason for hiding this comment

cth-usq May 1, 2024 •

edited

Loading