Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution? #23

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Solution? #23

wants to merge 8 commits into from

Conversation

OKochubeii
Copy link

No description provided.

Copy link

@NazarSheremet NazarSheremet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but fix EoF

apiVersion: v1
kind: Namespace
metadata:
name: {{ .Values.mysql.namespace }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Add Eof(End-of-file), need to add blank line at the end

data:
{{- range $k, $v := .Values.mysql.secrets }}
{{ $k }}: {{ $v | b64enc}}
{{- end }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Eof(End-of-file), need to add blank line at the end

Comment on lines 15 to 17
# pod-name.service-name.namespace.svc.cluster.local
# pod-name.service-name
# mysql-0.mysql.mysql.svc.cluster.local

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to leave these comments in the PR

name: {{ .Chart.Name }}-config
namespace: {{ .Values.todoapp.namespace }}
data:
PYTHONUNBUFFERED: "1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Eof(End-of-file), need to add blank line at the end

- key: app
operator: In
values:
- kube2py

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Eof(End-of-file), need to add blank line at the end

service:
name: {{ .Chart.Name }}-service
port:
number: {{ .Values.todoapp.service.port }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Eof(End-of-file), need to add blank line at the end

apiVersion: v1
kind: Namespace
metadata:
name: {{ .Values.todoapp.namespace }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Eof(End-of-file), need to add blank line at the end

- ReadWriteMany
resources:
requests:
storage: {{ .Values.todoapp.volumes.persistentVolumeClaim.requestStorage }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Eof(End-of-file), need to add blank line at the end

roleRef:
kind: Role
name: secrets-reader
apiGroup: rbac.authorization.k8s.io

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Eof(End-of-file), need to add blank line at the end

Copy link

@NazarSheremet NazarSheremet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants