Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #7

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Solution #7

wants to merge 10 commits into from

Conversation

IKruglyak
Copy link

No description provided.

YuriiSmolii
YuriiSmolii suggested changes May 9, 2024
View reviewed changes
Copy link

@YuriiSmolii YuriiSmolii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зверни увагу на автоматичне тестування. Потрібно виправляти помилки.

image

@IKruglyak IKruglyak requested a review from YuriiSmolii May 14, 2024 11:58
YuriiSmolii
YuriiSmolii suggested changes May 14, 2024
View reviewed changes
Copy link

@YuriiSmolii YuriiSmolii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Виконай команду та запуш у репозиторій для перевірки.

@IKruglyak IKruglyak requested a review from YuriiSmolii May 14, 2024 17:34
NazarSheremet
NazarSheremet suggested changes May 15, 2024
View reviewed changes
Copy link

@NazarSheremet NazarSheremet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, clean your PR:

  • Why charts and values duplicate with different names?
    image
    image

  • Templetes for mysql duplicates too: charts/mysql/templetes and charts/mysql/templetes

  • Also templetes for todoapp duplicates: /template and /todoapp/templetes

@IKruglyak IKruglyak requested a review from NazarSheremet May 16, 2024 09:29
YuriiSmolii
YuriiSmolii suggested changes May 16, 2024
View reviewed changes
Copy link

@YuriiSmolii YuriiSmolii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Чомусь автоматичне тестування не запустилось, зроби додатковий пробний коміт щоб тригернути автоматичне тестування.

@IKruglyak IKruglyak requested a review from YuriiSmolii May 17, 2024 10:51
YuriiSmolii
YuriiSmolii suggested changes May 17, 2024
View reviewed changes
Copy link

@YuriiSmolii YuriiSmolii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Потрібно тригернути запуск тестів, спробуй це зробити вручну або за доп. ногово коміта.

@IKruglyak IKruglyak requested a review from YuriiSmolii May 18, 2024 06:17
NazarSheremet
NazarSheremet approved these changes May 19, 2024
View reviewed changes
Copy link

@NazarSheremet NazarSheremet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NazarSheremet NazarSheremet NazarSheremet approved these changes

@YuriiSmolii YuriiSmolii Awaiting requested review from YuriiSmolii

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IKruglyak @YuriiSmolii @NazarSheremet