solution #29
solution #29
Conversation
There was a problem hiding this comment.
Great job on meeting the core requirements of the task! 🎉 The RBAC configuration is mostly correct, with the necessary ServiceAccount, Role, and RoleBinding definitions in place. Just a few minor tweaks are needed: ensure the apiGroup for ServiceAccount subjects is empty, and double-check if pods should be included in the resources. Also, consider whether the commented-out ingress line in bootstrap.sh is intentional. Keep up the good work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| name: secrets-reader # name of the user, group or service account. | ||
| apiGroup: rbac.authorization.k8s.io # this is always "rbac.authorization.k8s.io". |
There was a problem hiding this comment.
The apiGroup for the subjects section should be empty ("") for ServiceAccount subjects, as they belong to the core API group. The current value rbac.authorization.k8s.io is incorrect.
| name: secrets-lister-role # This is the name of the role | ||
| rules: | ||
| - apiGroups: [""] # "" indicates the core API group, which includes all core APIs | ||
| resources: ["pods", "secrets"] # Indicates the resources that the role can access, in this case, pods |
There was a problem hiding this comment.
The resources field includes pods, which might not be necessary if the intention is only to list and get secrets. Ensure that pods is intentionally included here.
| @@ -14,7 +14,7 @@ kubectl apply -f .infrastructure/app/clusterIp.yml | |||
| kubectl apply -f .infrastructure/app/nodeport.yml | |||
| kubectl apply -f .infrastructure/app/hpa.yml | |||
| kubectl apply -f .infrastructure/app/deployment.yml | |||
|
|
|||
| kubectl apply -f .infrastructure/security/rbac.yml | |||
| # Install Ingress Controller | |||
| kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/main/deploy/static/provider/kind/deploy.yaml | |||
| # kubectl apply -f .infrastructure/ingress/ingress.yml | |||
There was a problem hiding this comment.
The line for applying the ingress configuration is commented out. If the ingress is needed for your application, ensure to uncomment this line. Otherwise, if it's intentional, you can leave it as is.
No description provided.