-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #32
base: main
Are you sure you want to change the base?
Solution #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your submission! 🎉 Your code meets the task requirements and constraints, and you've done well in setting up the RBAC configuration and deployment for the 'todoapp'. Here are a few points to consider for improvement:
- Liveness and Readiness Probes: Ensure that the paths specified in the probes are correct and accessible to avoid the application being marked as unhealthy.
- Ingress Resource: The Ingress resource application is commented out in your
bootstrap.sh
script. If you plan to use Ingress for routing, consider uncommenting this line to apply the configuration.
Overall, your solution is well-structured and fulfills the task requirements. Keep up the good work, and make sure to address the mentioned issues to enhance your application's functionality. This decision is made to help you move forward with your learning journey. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
@@ -15,6 +15,8 @@ kubectl apply -f .infrastructure/app/nodeport.yml | |||
kubectl apply -f .infrastructure/app/hpa.yml | |||
kubectl apply -f .infrastructure/app/deployment.yml | |||
|
|||
kubectl apply -f .infrastructure/security/rbac.yml | |||
|
|||
# Install Ingress Controller | |||
kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/main/deploy/static/provider/kind/deploy.yaml | |||
# kubectl apply -f .infrastructure/ingress/ingress.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Ingress resource application is commented out. If you intend to use Ingress for routing, consider uncommenting this line to apply the Ingress configuration.
No description provided.