Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solved #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

solved #33

wants to merge 1 commit into from

Conversation

NikitaLafinskiy
Copy link

No description provided.

@NikitaLafinskiy
Copy link
Author

Uploading Screenshot_20241215_122037.png…

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on setting up the deployment configuration and RBAC for the 'todoapp'! 🎉 The critical components are in place, and you've ensured that the necessary files and instructions are well-prepared. While there are some commented-out sections, such as the ingress, NodePort service, and MySQL resources, it seems like you've intentionally left them out for now. Just make sure to address these if they become necessary for your application's functionality. Keep up the good work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +2 to +6
# kubectl apply -f .infrastructure/mysql/ns.yml
# kubectl apply -f .infrastructure/mysql/configMap.yml
# kubectl apply -f .infrastructure/mysql/secret.yml
# kubectl apply -f .infrastructure/mysql/service.yml
# kubectl apply -f .infrastructure/mysql/statefulSet.yml

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines are commented out, which means the MySQL resources will not be applied. Ensure this is intentional and that MySQL is either not needed or is managed separately.


kubectl apply -f .infrastructure/app/ns.yml
# kubectl apply -f .infrastructure/app/ns.yml

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The namespace for the app is commented out. Make sure the namespace already exists or is created by another means before applying other resources.

kubectl apply -f .infrastructure/app/pv.yml
kubectl apply -f .infrastructure/app/pvc.yml
kubectl apply -f .infrastructure/app/secret.yml
kubectl apply -f .infrastructure/app/configMap.yml
kubectl apply -f .infrastructure/app/clusterIp.yml
kubectl apply -f .infrastructure/app/nodeport.yml
# kubectl apply -f .infrastructure/app/nodeport.yml

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NodePort service is commented out. If external access to the application is needed, ensure that this is configured appropriately elsewhere.

Comment on lines +20 to 21
# kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/main/deploy/static/provider/kind/deploy.yaml
# kubectl apply -f .infrastructure/ingress/ingress.yml

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ingress-related commands are commented out. If you require ingress for your application, make sure to uncomment these lines or manage ingress separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants