-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solved #33
base: main
Are you sure you want to change the base?
solved #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on setting up the deployment configuration and RBAC for the 'todoapp'! 🎉 The critical components are in place, and you've ensured that the necessary files and instructions are well-prepared. While there are some commented-out sections, such as the ingress, NodePort service, and MySQL resources, it seems like you've intentionally left them out for now. Just make sure to address these if they become necessary for your application's functionality. Keep up the good work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
# kubectl apply -f .infrastructure/mysql/ns.yml | ||
# kubectl apply -f .infrastructure/mysql/configMap.yml | ||
# kubectl apply -f .infrastructure/mysql/secret.yml | ||
# kubectl apply -f .infrastructure/mysql/service.yml | ||
# kubectl apply -f .infrastructure/mysql/statefulSet.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines are commented out, which means the MySQL resources will not be applied. Ensure this is intentional and that MySQL is either not needed or is managed separately.
|
||
kubectl apply -f .infrastructure/app/ns.yml | ||
# kubectl apply -f .infrastructure/app/ns.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The namespace for the app is commented out. Make sure the namespace already exists or is created by another means before applying other resources.
kubectl apply -f .infrastructure/app/pv.yml | ||
kubectl apply -f .infrastructure/app/pvc.yml | ||
kubectl apply -f .infrastructure/app/secret.yml | ||
kubectl apply -f .infrastructure/app/configMap.yml | ||
kubectl apply -f .infrastructure/app/clusterIp.yml | ||
kubectl apply -f .infrastructure/app/nodeport.yml | ||
# kubectl apply -f .infrastructure/app/nodeport.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The NodePort service is commented out. If external access to the application is needed, ensure that this is configured appropriately elsewhere.
# kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/main/deploy/static/provider/kind/deploy.yaml | ||
# kubectl apply -f .infrastructure/ingress/ingress.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ingress-related commands are commented out. If you require ingress for your application, make sure to uncomment these lines or manage ingress separately.
No description provided.