Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Solution #29

wants to merge 2 commits into from

Conversation

Muskam09
Copy link

No description provided.

YuriiSmolii
YuriiSmolii reviewed Aug 31, 2024
View reviewed changes
Copy link

@YuriiSmolii YuriiSmolii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor namespaces, fix and remember to keep EOF's

infrastructure/busybox.yml Outdated
image: radial/busyboxplus:curl
args:
- sleep
- "1000"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOF

infrastructure/namespace.yml Outdated
apiVersion: v1
kind: Namespace
metadata:
name: todoapp
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOF

infrastructure/todoapp-pod.yml Outdated
path: api/ready
port: 8080
initialDelaySeconds: 5
periodSeconds: 5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOF

src/Dockerfile Outdated
EXPOSE 8080

# Run database migrations and start the Django application
ENTRYPOINT [ "sh", "-c", "python manage.py migrate && python manage.py runserver 0.0.0.0:8080" ]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOF

src/api/views.py Outdated
return HttpResponse("Not Ready", status=status.HTTP_503_SERVICE_UNAVAILABLE)
else:
return HttpResponse("Ready", status=status.HTTP_200_OK)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOF

src/todolist/settings.py Outdated


START_TIME = time.time()
START_PERIOD = 40
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOF

infrastructure/busybox.yml
apiVersion: v1
kind: Pod
metadata:
name: busybox
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namespace?

infrastructure/todoapp-pod.yml Outdated
kind: Pod
metadata:
name: todoapp
namespace: mateapp
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why namespace=mateapp?

YuriiSmolii
YuriiSmolii suggested changes Aug 31, 2024
View reviewed changes
Copy link

@YuriiSmolii YuriiSmolii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested.

@Muskam09 Muskam09 requested a review from YuriiSmolii September 3, 2024 16:34
NazarSheremet
NazarSheremet approved these changes Sep 5, 2024
View reviewed changes
Copy link

@NazarSheremet NazarSheremet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NazarSheremet NazarSheremet NazarSheremet approved these changes

@YuriiSmolii YuriiSmolii Awaiting requested review from YuriiSmolii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Muskam09 @YuriiSmolii @NazarSheremet