Develop #44
Develop #44
Conversation
There was a problem hiding this comment.
Your submission is almost there! 🚀 However, there are a few critical issues that need to be addressed before we can approve it. Please add the missing Dockerfile and INSTRUCTION.md file, and update the image name in todoapp-pod.yml to match the specified format {yourname}/todoapp:3.0.0. Once these changes are made, your solution will meet all the task requirements. Keep up the great work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
There was a problem hiding this comment.
Great job on your progress! 🎉 While your Pull Request is approved to help you move forward with your learning, there are a few important issues to address:
-
Dockerfile: The
Dockerfileis missing. This is essential for building the Docker image for the ToDo application. Please ensure to include it. -
INSTRUCTION.md: This file is missing and should contain instructions on applying all manifests, testing the ToDo application using the
port-forwardcommand, and testing the application using thebusyboxplus:curlcontainer. -
Image Name in
todoapp-pod.yml: The image name should follow the format{yourname}/todoapp:3.0.0. Currently, it is set todumavb/todoapp3. Please update it accordingly. -
Pod Name: The
namefield should not contain a version number. It should simply betodoapp, with the version being part of the image tag instead.
Please review these comments to improve your code. Addressing these issues will enhance the functionality and maintainability of your application. Keep up the good work and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| apiVersion: v1 | ||
| kind: Pod | ||
| metadata: | ||
| name: todoapp:3.0.0 |
There was a problem hiding this comment.
The name field should not contain a version number. It should simply be todoapp. The version should be part of the image tag, not the Pod name.
| spec: | ||
| containers: | ||
| - name: todoapp | ||
| image: dumavb/todoapp3 |
There was a problem hiding this comment.
The image name does not match the specified format {yourname}/todoapp:3.0.0. Please update it to follow this format.
No description provided.