-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #26
base: main
Are you sure you want to change the base?
Solution #26
Conversation
.infrastructure/todoapp-pod.yml
Outdated
path: api/ready | ||
port: 8080 | ||
initialDelaySeconds: 5 | ||
periodSeconds: 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.infrastructure/todoapp-pod.yml
Outdated
- name: DEBUG | ||
value: "false" | ||
- name: API_URL | ||
value: "http://todoapp-clusterip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these variables needed for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variable for Django debugging https://docs.djangoproject.com/en/5.1/ref/settings/#debug
if I correctly undestood task (task 6 Set all env values for the container from pod’s manifest)
https://kubernetes.io/docs/tasks/inject-data-application/define-environment-variable-container/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable that needs to be added is PYTHONUNBUFFERED
. Adding DEBUG
doesn't make sense since its default value is already false. Also, I don't see the need for API_URL
.infrastructure/todoapp-pod.yml
Outdated
- name: DEBUG | ||
value: "false" | ||
- name: API_URL | ||
value: "http://todoapp-clusterip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable that needs to be added is PYTHONUNBUFFERED
. Adding DEBUG
doesn't make sense since its default value is already false. Also, I don't see the need for API_URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
No description provided.