Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #26

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Solution #26

wants to merge 6 commits into from

Conversation

volry
Copy link

@volry volry commented Sep 1, 2024

No description provided.

path: api/ready
port: 8080
initialDelaySeconds: 5
periodSeconds: 5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Eof(End-of-file), need to add a blank line at the end
image

Comment on lines 51 to 54
- name: DEBUG
value: "false"
- name: API_URL
value: "http://todoapp-clusterip"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these variables needed for?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable for Django debugging https://docs.djangoproject.com/en/5.1/ref/settings/#debug
if I correctly undestood task (task 6 Set all env values for the container from pod’s manifest)
https://kubernetes.io/docs/tasks/inject-data-application/define-environment-variable-container/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable that needs to be added is PYTHONUNBUFFERED. Adding DEBUG doesn't make sense since its default value is already false. Also, I don't see the need for API_URL

@volry volry requested a review from NazarSheremet September 2, 2024 17:00
Comment on lines 51 to 54
- name: DEBUG
value: "false"
- name: API_URL
value: "http://todoapp-clusterip"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable that needs to be added is PYTHONUNBUFFERED. Adding DEBUG doesn't make sense since its default value is already false. Also, I don't see the need for API_URL

@volry volry requested a review from NazarSheremet September 4, 2024 12:59
Copy link

@NazarSheremet NazarSheremet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants