Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s: add services #37

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

nmakivchuk
Copy link

No description provided.

Copy link

@NazarSheremet NazarSheremet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix EoF

.infrastructure/cluster-ip.yml Outdated Show resolved Hide resolved
.infrastructure/nodeport.yml Outdated Show resolved Hide resolved
.infrastructure/todoapp-pod.yml Outdated Show resolved Hide resolved
@nmakivchuk
Copy link
Author

Could you please explain me why it's so necessary add blank line? Thanks in advance

Copy link

@Alkaponees Alkaponees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my review

README.md Show resolved Hide resolved
Copy link

@Alkaponees Alkaponees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@Alkaponees
Copy link

Could you please explain me why it's so necessary add blank line? Thanks in advance

Version control systems like Git may show unnecessary differences if there’s no newline at the end of a file. For instance:

If you add a new line to a file without a newline at the end, Git will detect a change to the last line as well as the new line, even though logically only the new line was added.

@nmakivchuk
Copy link
Author

Thanks a lot 😊

@nmakivchuk
Copy link
Author

@Alkaponees by the way, do you know maybe good terminal app for Android cellphone, i want to try do some tasks on my cellphone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants