Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all change #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

all change #42

wants to merge 1 commit into from

Conversation

Greena1c
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on setting up the Kubernetes manifests! 🎉 The configuration is well done, and the services are ready for deployment. While the setup is functional, consider using a Deployment or ReplicaSet for managing multiple pod instances in the future. This will enhance scalability and manageability. Keep up the good work, and don't forget to add the INSTRUCTION.md file to guide users on testing the app. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -21,3 +30,37 @@ spec:
port: 8080
initialDelaySeconds: 5
periodSeconds: 5

---

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a Deployment or ReplicaSet instead of defining multiple pods manually. This approach provides better scalability and management of pod replicas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants