Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #44

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Solution #44

wants to merge 1 commit into from

Conversation

vrudkovsky
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the implementation! 🎉 The code meets all the task requirements, and the Kubernetes manifests are well-structured. Just double-check the selector labels in your service manifests to ensure they match the pod labels. This will ensure proper traffic routing. Keep up the excellent work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +7 to +8
selector:
app: todolist

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the 'app: todolist' label matches the labels defined in the pod specifications. If the pods are labeled differently, the service will not be able to route traffic to them.

Comment on lines +8 to +9
selector:
app: todolist

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the 'app: todolist' label matches the labels defined in the pod specifications. If the pods are labeled differently, the service will not be able to route traffic to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants