Solution #40
Solution #40
Conversation
There was a problem hiding this comment.
Great job on your submission! 🎉 You've met the core requirements of the task, and your configuration files are well-structured. Just a few minor tweaks to consider: fix the typo in the INSTRUCTION.md file from prinenv to printenv, and remember to set DEBUG to False in production for security. Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| kubectl get pods | ||
| kubectl exec -it <pod-name> -- /bin/sh | ||
| prinenv |
There was a problem hiding this comment.
There is a typo in the command prinenv. It should be printenv to correctly display the environment variables inside the pod.
| @@ -18,7 +18,7 @@ | |||
| # See https://docs.djangoproject.com/en/1.7/howto/deployment/checklist/ | |||
|
|
|||
| # SECURITY WARNING: keep the secret key used in production secret! | |||
| SECRET_KEY = "@e2(yx)v&tgh3_s=0yja-i!dpebxsz^dg47x)-k&kq_3zf*9e*" | |||
| SECRET_KEY = os.getenv('SECRET_KEY') | |||
There was a problem hiding this comment.
The SECRET_KEY is being retrieved from an environment variable, which is a good practice for security. Ensure that the environment variable is set correctly in all environments where the application is deployed.
| @@ -18,7 +18,7 @@ | |||
| # See https://docs.djangoproject.com/en/1.7/howto/deployment/checklist/ | |||
|
|
|||
| # SECURITY WARNING: keep the secret key used in production secret! | |||
| SECRET_KEY = "@e2(yx)v&tgh3_s=0yja-i!dpebxsz^dg47x)-k&kq_3zf*9e*" | |||
| SECRET_KEY = os.getenv('SECRET_KEY') | |||
|
|
|||
| # SECURITY WARNING: don't run with debug turned on in production! | |||
| DEBUG = True | |||
There was a problem hiding this comment.
The DEBUG setting is set to True. This should be set to False in production to avoid exposing sensitive information.
| # "HOST": "FVFFM3F5Q05N", | ||
| # "PORT": 3306, | ||
| # "NAME":"tododb", | ||
| # "PASSWORD": "my-secret-pw", | ||
| # "PASSWORD": "my-secret-pw", |
There was a problem hiding this comment.
The MySQL database configuration is commented out, but it includes a hardcoded password. It's recommended to use environment variables for sensitive information like database passwords.
No description provided.