Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #10

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Solution #10

wants to merge 14 commits into from

Conversation

Serveladik
Copy link

No description provided.

NazarSheremet
NazarSheremet suggested changes Sep 22, 2024
View reviewed changes
Copy link

@NazarSheremet NazarSheremet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but why you use private key of vm for connection, if it can be done by your pub key

@Serveladik
Copy link
Author

Looks good, but why you use private key of vm for connection, if it can be done by your pub key

why is that a problem? i dont know
I did test vm creation, so it works via this method, and also in some sort of docs said that we need to use private key for connection

YuriiSmolii
YuriiSmolii approved these changes Sep 23, 2024
View reviewed changes
Copy link

@YuriiSmolii YuriiSmolii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriiSmolii YuriiSmolii YuriiSmolii approved these changes

@NazarSheremet NazarSheremet Awaiting requested review from NazarSheremet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Serveladik @YuriiSmolii @NazarSheremet