Develop #1030
Develop #1030
Conversation
IrynaMariiko00
commented
Nov 11, 2024
IrynaMariiko00
commented
- DEMO LINK
src/scripts/main.js
Outdated
| }); | ||
|
|
||
| if (game.status === WIN || game.status === LOSE) { | ||
| hideMessage(); |
src/modules/Game.class.js
Outdated
| // Затримка для видалення класу 'merged' після завершення анімації | ||
| setTimeout(() => { | ||
| toCell.classList.remove('merged'); | ||
| }, 300); // Час анімації (300ms) |
There was a problem hiding this comment.
If you change some property in merged class you should add transition for this property in scss file
Now it doesn't work (but not required in the task - so it's only a suggestion)
src/modules/Game.class.js
Outdated
| cell.textContent = ''; | ||
| } else { | ||
| cell.classList.add(`field-cell--${value}`); | ||
| cell.textContent = value; // оновлюємо текст |
There was a problem hiding this comment.
it's clear without comment 🙂 And it's related to 90% of comments - no need to comment smth if it's clear from the code. If there is complicated logic, unusual behavior, etc. we need to add comments
There was a problem hiding this comment.
oh, sorry, I wrote it for myself and forgot to delete it
src/scripts/main.js
Outdated
| } | ||
| } | ||
|
|
||
| // Функція для відображення рекорду |
There was a problem hiding this comment.
Remove all comments
| // Функція для відображення рекорду |
src/styles/main.scss
Outdated
| .message-lose { | ||
| width: 100%; | ||
| box-sizing: border-box; | ||
| height: 60px !important; |
There was a problem hiding this comment.
Don't use important, it's a bad practice
| height: 60px !important; | |
| height: 60px; |
|
I have improved my code again. Could you look at it, please? |
