Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2048 reviev 1 #1056

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

2048 reviev 1 #1056

wants to merge 11 commits into from

Conversation

nikalaiii
Copy link

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Add a favicon on the page
image

After the loss notification, the movement continues in blocks, you need to correct the logic
image

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic still broken.
See screencast. I always make right move, but cells sometimes changes randomly.

Screen.Recording.2024-12-02.at.17.19.37.mov

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to remove lose message on restart button click
image

Comment on lines 206 to 209
filtered[i] *= 2; // Об'єднуємо
filtered[i + 1] = 0; // Обнуляємо наступну клітинку
merged[i] = true; // Відзначаємо злиття
this.score += filtered[i]; // Додаємо очки

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to write comments only in English

@nikalaiii nikalaiii requested a review from etojeDenys December 3, 2024 20:04
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants