add silution #1067
Open
add silution #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorbachovam00
commented
Dec 9, 2024
gorbachovam00
commented
- DEMO LINK
VitaliyBondarenko1982
suggested changes
Dec 9, 2024
src/scripts/main.js
Outdated
| // startButton.textContent = 'Restart'; | ||
| // updateUI(); | ||
| // checkGameStatus(); | ||
| // }); |
There was a problem hiding this comment.
do not keep commented code
src/scripts/main.js
Outdated
| }); | ||
|
|
||
| document.addEventListener('keydown', (event) => { | ||
| if (game.getStatus() !== 'IN_PROGRESS') { |
There was a problem hiding this comment.
move to constants statuses.
better to palce all statuces strings in object.
src/scripts/main.js
Outdated
| 'use strict'; | ||
|
|
||
| // Uncomment the next lines to use your game instance in the browser | ||
| // const Game = require('../modules/Game.class'); | ||
| // const game = new Game(); | ||
|
|
||
| // Write your code here | ||
| class Game { |
There was a problem hiding this comment.
why you wrote class Game in main.js?
move code to /modules/Game.class and import here (uncomment code above)
etojeDenys
suggested changes
Dec 11, 2024
VitaliyBondarenko1982
suggested changes
Dec 12, 2024
volodymyr-soltys97
suggested changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.