Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #1082

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #1082

wants to merge 2 commits into from

Conversation

naz4ik
Copy link

@naz4ik naz4ik commented Dec 16, 2024 •
edited
Loading

etojeDenys
etojeDenys suggested changes Dec 16, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not create the cell if the board didn't change

Screen.Recording.2024-12-16.at.11.53.26.mov

src/scripts/main.js Outdated
Comment on lines 57 to 64
if (keyboardEvent.key === 'ArrowUp') {
game.moveUp();
} else if (keyboardEvent.key === 'ArrowDown') {
game.moveDown();
} else if (keyboardEvent.key === 'ArrowLeft') {
game.moveLeft();
} else if (keyboardEvent.key === 'ArrowRight') {
game.moveRight();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to use switch case here

@naz4ik naz4ik requested a review from etojeDenys December 16, 2024 10:07
etojeDenys
etojeDenys approved these changes Dec 16, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naz4ik @etojeDenys