solution applied #2179
solution applied #2179
Conversation
There was a problem hiding this comment.
Great job on implementing the formatDate function! 🎉 Your solution meets the task requirements and constraints effectively. While there are a couple of minor issues regarding the conversion of two-digit years and handling separators, these do not significantly impact the functionality. Keep up the good work, and consider the feedback for future improvements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| const oldSeparator = fromFormat.pop(); | ||
| const newSeparator = toFormat.pop(); |
There was a problem hiding this comment.
Popping the last element from fromFormat and toFormat to get the separators might not be reliable if the formats don't end with the separator. Consider explicitly passing the separator as a separate argument or ensuring the format arrays are structured to include separators as the last element.
|
|
||
| if (key === 'YY' && toFormat.includes('YYYY')) { | ||
| key = 'YYYY'; | ||
| value = parseInt(value) < 30 ? 20 + value : 19 + value; |
There was a problem hiding this comment.
The logic for converting two-digit years to four-digit years is incorrect. The expression 20 + value and 19 + value will concatenate strings instead of adding numbers. Use parseInt(value, 10) to ensure numeric addition.
No description provided.