Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #2182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #2182

wants to merge 1 commit into from

Conversation

troleksii
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the formatDate function! 🎉 Your code meets the task requirements and constraints effectively, handling the date conversion as expected. While there is a minor assumption about the separator's position, it doesn't critically impact the functionality for the given task. Keep up the good work, and consider exploring more robust ways to handle separators in future projects. Your attention to detail is commendable! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +11 to +12
const [fromParts, separator] = [fromFormat.slice(0, -1), fromFormat[3]];
const [toParts, separatorNew] = [toFormat.slice(0, -1), toFormat[3]];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assumption that the separator is at index 3 in both fromFormat and toFormat might not always be correct. If the format strings are not exactly 4 characters long, this will lead to incorrect behavior. Consider using a different approach to determine the separator, such as checking for non-alphanumeric characters in the format string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants