Solution #2184
Solution #2184
Conversation
There was a problem hiding this comment.
Great job on implementing the formatDate function! 🎉 Your solution meets the task requirements and constraints effectively. The function handles date conversion and formatting as expected, including the conversion between 2-digit and 4-digit years. While there are a couple of minor points regarding the use of fixed indices for separators in the join and split methods, these do not critically impact the functionality. Keep up the good work, and consider dynamically determining the separator for future improvements. Well done! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/formatDate.js
Outdated
| @@ -8,7 +8,25 @@ | |||
| * @returns {string} | |||
| */ | |||
| function formatDate(date, fromFormat, toFormat) { | |||
| // write code here | |||
| const dateParts = date.split(fromFormat[3]); | |||
There was a problem hiding this comment.
The split method uses fromFormat[3] as the delimiter, assuming the separator is always at this index. This might not be correct if the format array doesn't have a separator at index 3. Consider dynamically determining the separator based on the format string.
src/formatDate.js
Outdated
| result[toFormat.indexOf('YYYY')] = year; | ||
| } | ||
|
|
||
| return result.join(toFormat[3]); |
There was a problem hiding this comment.
The join method uses toFormat[3] as the separator, assuming the separator is always at this index. This might not be correct if the format array doesn't have a separator at index 3. Consider dynamically determining the separator based on the format string.
No description provided.