add task solution #2188
add task solution #2188
Conversation
There was a problem hiding this comment.
Great job on implementing the formatDate function! 🎉 Your solution meets the task requirements and constraints effectively. While there are a couple of areas for improvement, such as ensuring the loop includes all elements of toFormat and correcting the logic for converting 'YY' to 'YYYY', these are minor issues that don't significantly impact the core functionality. Keep up the good work, and consider these suggestions for future enhancements. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| dateObject['YYYY'] = | ||
| +dateObject['YY'] < 30 | ||
| ? `20${dateObject['YY']}` | ||
| : `19${dateObject['YY']}`; |
There was a problem hiding this comment.
The logic for converting 'YY' to 'YYYY' is incorrect. The expression +dateObject['YY'] < 30 will always evaluate to a boolean, which is not the intended behavior. You should use parentheses to ensure the correct order of operations, like this: (+dateObject['YY'] < 30) ? ....
| for (const name of toFormat.slice(0, -1)) { | ||
| newDate.push(dateObject[name]); | ||
| } |
There was a problem hiding this comment.
The loop iterates over toFormat.slice(0, -1), which means it excludes the last element of toFormat. This might not be the intended behavior if you want to include all elements in the toFormat array. Consider revising this logic if you want to include the last element.
Add solution.