Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #2190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #2190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions src/formatDate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,38 @@
* @returns {string}
*/
function formatDate(date, fromFormat, toFormat) {
// write code here
}
const partsDate = date.split(fromFormat[3]);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code assumes that the separator is always at index 3 in the fromFormat array. This assumption may not hold true for all date formats. Consider dynamically determining the separator based on the format string.

let year = 0;

if (fromFormat.includes('YY')) {
year = parseInt(partsDate[fromFormat.indexOf('YY')]);
year = year < 30 ? 2000 + year : 1900 + year;
} else {
year = partsDate[fromFormat.indexOf('YYYY')];
}

const month = partsDate[fromFormat.indexOf('MM')];
const day = partsDate[fromFormat.indexOf('DD')];

const newSper = toFormat[3];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the issue with fromFormat, the code assumes that the separator is at index 3 in the toFormat array. This might not be correct for all formats. Consider a more flexible approach to determine the separator.


toFormat.pop();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the last element of toFormat using pop() might not be the correct approach if the separator is not at the last position. This could lead to incorrect date formatting.


const newDateString = toFormat
.map((part) => {
switch (part) {
case 'YYYY':
return year;
case 'YY':
return year.toString().slice(-2);
case 'MM':
return month;
case 'DD':
return day;
}
})
.join(newSper);

return newDateString;
}
module.exports = formatDate;
Loading