solved the task jv-oop-advanced #1285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1sam
suggested changes
Oct 2, 2023
| @@ -0,0 +1,5 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public interface Printer { | |||
There was a problem hiding this comment.
If you have method draw() maybe does it better to have class name as Drawer?
| } | ||
|
|
||
| public Figure getDefaultFigure() { | ||
| return new Circle(Color.WHITE.name(), 10); |
There was a problem hiding this comment.
All magic numbers in your code should be constants.
Please see this article to learn about constant fields and their naming requirements.
bhdnchui
approved these changes
Oct 3, 2023
Comment on lines
+9
to
+10
| int index = random.nextInt(Color.values().length); | ||
| return Color.values()[index].name(); |
There was a problem hiding this comment.
I think you can storeColor.values() result as a class field.
Comment on lines
+14
to
+15
| int figureNumber = random.nextInt(FIGURE_COUNT); | ||
| switch (figureNumber) { |
There was a problem hiding this comment.
You can simplify it with switch (random.nextInt(FIGURE_COUNT)).
|
|
||
| public static void main(String[] args) { | ||
| FigureSupplier figureSupplier = new FigureSupplier(); | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.