Solved tasks from ReadMe file #1292
Conversation
| @@ -0,0 +1,10 @@ | |||
| package core.basesyntax.enums; | |||
|
|
|||
| public enum FigureColor { | |||
| package core.basesyntax.figures; | ||
|
|
||
| public interface Drawable { | ||
| void toDraw(); |
| protected int area; | ||
|
|
||
| @Override | ||
| public void toDraw() { |
There was a problem hiding this comment.
You can make thin class abstract and not override a method with empty implementation.
| for (int i = 0; i < ARRAY_LENGTH; i++) { | ||
| if (i < ARRAY_LENGTH / 2) { | ||
| figures[i] = figureSupplier.getRandomFigure(); | ||
| continue; |
There was a problem hiding this comment.
Do not use continue, use just if {} else {}.
|
|
||
| public class ColorSupplier { | ||
| private final Random random = new Random(); | ||
| private final int randomIndex = random.nextInt(FigureColor.values().length); |
There was a problem hiding this comment.
This random index will be created once on creating ColorSupplier.
I think you should have a random index on every getRandomColor method call.
| if (randomIndex == 0) { | ||
| return new Circle(randomColor, randomProperty1); | ||
| } | ||
| if (randomIndex == 1) { | ||
| return new IsoscelesTrapezoid(randomColor, | ||
| randomProperty1, randomProperty2, randomProperty3); | ||
| } | ||
| if (randomIndex == 2) { | ||
| return new Rectangle(randomColor, randomProperty1, randomProperty2, randomProperty3); | ||
| } | ||
| if (randomIndex == 3) { | ||
| return new RightTriangle(randomColor, randomProperty1, randomProperty2); | ||
| } |
There was a problem hiding this comment.
Looks like a custom switch. Lets use default java switch.
| int randomProperty1 = random.nextInt(MAX_VALUE_OF_PROPERTY); | ||
| int randomProperty2 = random.nextInt(MAX_VALUE_OF_PROPERTY); | ||
| int randomProperty3 = random.nextInt(MAX_VALUE_OF_PROPERTY); |
There was a problem hiding this comment.
I think it is redundant. You can create object with the text logic:
return new Circle(colorSupplier.getRandomColor(), getRandomValue());
| int randomProperty1 = random.nextInt(MAX_VALUE_OF_PROPERTY); | ||
| int randomProperty2 = random.nextInt(MAX_VALUE_OF_PROPERTY); | ||
| int randomProperty3 = random.nextInt(MAX_VALUE_OF_PROPERTY); | ||
| String randomColor = new ColorSupplier().getRandomColor(); |
| this.sideEdge = sideEdge; | ||
| this.topSide = topSide; | ||
| this.downSide = downSide; | ||
| this.area = ((topSide * downSide) / 2) * sideEdge; |
There was a problem hiding this comment.
Does that formula calculate area of the isosceles trapezoid?
| this.firstSide = firstSide; | ||
| this.secondSide = secondSide; | ||
| this.thirdSide = thirdSide; | ||
| this.area = firstSide * secondSide * thirdSide; |
There was a problem hiding this comment.
How does Rectangle translate?
How do we calculate it's area?
No description provided.