add findByLogin and login foo #1158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliia-ponomarenko
suggested changes
Dec 24, 2024
| @@ -15,6 +15,12 @@ public class UserService { | |||
| * Return <code>null</code> if there is no suitable user | |||
| */ | |||
| public User findByEmail(String email) { | |||
| for (int i = 0; i < users.length; i++) { | |||
There was a problem hiding this comment.
Can you use a for-each loop?
| return null; | ||
| } | ||
|
|
| @@ -11,6 +13,14 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| UserService userService = new UserService(); | |||
There was a problem hiding this comment.
make it a class-level variable (private final)
| @@ -11,6 +13,14 @@ public class AuthenticationService { | |||
| * Return false in any other cases. | |||
| */ | |||
| public boolean login(String email, String password) { | |||
| UserService userService = new UserService(); | |||
| if (userService.findByEmail(email) == null) { | |||
There was a problem hiding this comment.
Can you call the method findByEmail only once? Let’s think about how to refactor this method
JJJazl
suggested changes
Dec 25, 2024
Co-authored-by: Safarov Renat <[email protected]>
JJJazl
approved these changes
Dec 25, 2024
| if (user == null) { | ||
| return false; | ||
| } | ||
| return user != null && user.getPassword().equals(password); |
There was a problem hiding this comment.
You check that user != null above, so we don't need to do it again
Suggested change
| return user != null && user.getPassword().equals(password); | |
| return user.getPassword().equals(password); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.