Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calendar #3984

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

calendar #3984

wants to merge 1 commit into from

Conversation

olga-wukelan
Copy link

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Dec 1, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the calendar with SCSS and following the task requirements! 🎉 The only thing to fix is the stylesheet link in your HTML file. Make sure to compile your SCSS into CSS and link to the CSS file instead. Keep up the good work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/index.html
Comment on lines 10 to +12
<link
rel="stylesheet"
href="styles/index.scss"
href="../src/main.scss"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is pointing to a SCSS file (../src/main.scss). Browsers cannot directly interpret SCSS files. You need to compile the SCSS into a CSS file and link to that CSS file instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olga-wukelan @mateacademy-ai-mentor