add solution #4009
add solution #4009
Conversation
There was a problem hiding this comment.
Great job on your work! 🎉 Your code meets most of the task requirements and constraints, and the overall structure is well-organized. The only minor issue is ensuring that the $side-calendar-day variable is correctly defined or imported to avoid any potential compilation errors. Keep up the good work, and consider this small adjustment for future improvements. Well done! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| width: $side-calendar-day; | ||
| height: $side-calendar-day; |
There was a problem hiding this comment.
The variable $side-calendar-day is used here, but it's not defined within this file. Ensure that it is defined elsewhere in your SCSS files or imported correctly to avoid compilation errors.
|
|
||
| @each $week-day, $index in $week-days { | ||
| .calendar--start-day-#{$week-day} :first-child { | ||
| margin-left: $index * ($side-calendar-day + 1); |
There was a problem hiding this comment.
The calculation for margin-left uses $side-calendar-day, which is undefined in this file. Make sure this variable is defined or imported to ensure the calculation works correctly.
DEMO LINK
TEST REPORT LINK
Changing 'month-lengh' and 'start-day' modifier in the code element
reflects in changing calendar layout
Each day has no modifiers, only class (eg. calendar__day)
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the Code Style Rules ❗️