Develop #4023
Develop #4023
Conversation
There was a problem hiding this comment.
Great job on your submission! 🎉 The code is well-structured, and you've effectively used SCSS and BEM methodologies. The calendar is functional and meets the task requirements. While there's a minor issue with the margin-left calculation, it doesn't impact the overall functionality. Keep up the good work, and consider refining the calculation for even better accuracy in future projects. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| .calendar--start-day-#{$day} :first-child { | ||
| margin-left: $calendar-day * $i + $i; |
There was a problem hiding this comment.
The calculation for margin-left might be incorrect. The expression $calendar-day * $i + $i should likely be $calendar-day * $i + $col-gap * $i to account for the gap between columns. Ensure that the gap is considered in the calculation.
DEMO LINK
TEST REPORT LINK
Changing 'month-lengh' and 'start-day' modifier in the code element
reflects in changing calendar layout
Each day has no modifiers, only class (eg. calendar__day)
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the [Code Style Rules ❗️]