Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create the calendar #4039

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anastasiiaboreiko
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • [x]Changing 'month-lengh' and 'start-day' modifier in the code element
    reflects in changing calendar layout

  • Each day has no modifiers, only class (eg. calendar__day)

  • [x]All Typical Mistakes from BEM lesson theory are checked.

  • [x]Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the calendar layout! 🎉 The code meets all the task requirements and constraints. Just a small note: there's a typo in the SCSS variable name $day-hight, which should be $day-height. Fixing this will prevent any potential confusion. Keep up the great work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -1,3 +1,72 @@
$day-hight: 100px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the variable name $day-hight. It should be $day-height to correctly represent the height of the day elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants