Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First commit for review #676

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

First commit for review #676

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c68637f
First commit for review
Mar 23, 2021
0ac284c
coment delete/class add
Mar 23, 2021
c5a93ad
leash classes was deleted
Mar 23, 2021
e9123b2
recommit whith cheanges
Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,11 @@ jobs:
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
- run: npm install
- run: npm start & sleep 5 && npm test
- name: Upload HTML report(backstop data)
if: ${{ always() }}
uses: actions/upload-artifact@v2
with:
name: report
path: backstop_data
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ node_modules
# Generated files
backstop_data
dist
.cache
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"@mate-academy/bemlint": "^0.1.1",
"@mate-academy/eslint-config": "*",
"@mate-academy/linthtml-config": "0.0.1",
"@mate-academy/scripts": "^0.2.0",
"@mate-academy/scripts": "^0.8.4",
"@mate-academy/stylelint-config": "*",
"backstopjs": "^5.0.1",
"eslint": "^5.16.0",
Expand Down
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Enclosures
Replace `<your_account>` with your Github username and copy the links to Pull Request description:
- [DEMO LINK](https://<your_account>.github.io/layout_enclosures/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_enclosures/report/html_report/)
- [DEMO LINK](https://NikolayButylkov.github.io/layout_enclosures/)
- [TEST REPORT LINK](https://NikolayButylkov.github.io/layout_enclosures/report/html_report/)

> Follow [this instructions](https://github.com/mate-academy/layout_task-guideline#how-to-solve-the-layout-tasks-on-github)
___
Expand Down
51 changes: 40 additions & 11 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,43 @@
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport"
content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0">
<meta http-equiv="X-UA-Compatible" content="ie=edge">
<title>Enclosures</title>
<link rel="stylesheet" href="./style.css">
</head>
<body>
<h1>Enclosures</h1>
</body>
<head>
<meta charset="UTF-8">
<meta name="viewport"
content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0">
<meta http-equiv="X-UA-Compatible" content="ie=edge">
<title>Enclosures</title>
<link rel="stylesheet" href="./style.css">
</head>

<body>
<div id="qa-block" class="biggestBox">
<div class="middleBox">
<div class="first">
In programming languages, a closure is a technique for implementing lexically
scoped name binding in a language with first-class functions. Operationally, a
closure is a record storing a function together with an environment.
</div>
</div>
</div>

<div class="biggestBox">
<div class="middleBox">
<div class="second">
У програмуванні замиканням називають підпрограму, що виконується в середовищі,
яке містить одну або більше зв’язаних змінних. Підпрограма має доступ до цих
змінних під час виконання.
</div>
</div>
</div>

<div class="biggestBox">
<div class="middleBox">
<div class="third">
Замыкание в программировании — функция первого класса, в теле которой
присутствуют ссылки на переменные, объявленные вне тела этой функции в
окружающем коде и не являющиеся её параметрами.
</div>
</div>
</div>
</body>
</html>
31 changes: 31 additions & 0 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
body {
background-color: #000;
padding: 0 12px;
}

.first,
.third,
.second {
/* box-sizing: border-box; */
background-color: #ddd;
border: 1px solid #e95d49;
padding: 10px;
margin: 0;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First - don't leave commented code.
Second - you don't need to create three separate classes here, it can be just one class.


.middleBox {
box-sizing: border-box;
background-color: #ffa500;
padding: 10px;
border: 1px solid #e95d49;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have same border and padding styles in three places.
Don't repeat yourself, create a common class for these styles.

}

.biggestBox {
box-sizing: border-box;
background-color: #308dc0;
width: 350px;
margin: 20px 0;
margin-bottom: 40px;
padding: 10px;
border: 1px solid #e95d49;
}