Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layout_enclosures #677

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

layout_enclosures #677

wants to merge 2 commits into from

Conversation

YevgeniyaVoronina
Copy link

@YevgeniyaVoronina YevgeniyaVoronina commented Mar 23, 2021 •
edited
Loading

aliceblunt8
aliceblunt8 suggested changes Mar 24, 2021
View reviewed changes
src/index.html Outdated
Comment on lines 13 to 17
<section class="section">
<div class="text">
In programming languages, a closure is a technique for implementing lexically scoped name binding in a language with first-class functions. Operationally, a closure is a record storing a function together with an environment.
</div>
</section>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

watch yesterday's lecture till minute 8 and configure VScode auto-formatting for wrapping lines with more than 80 symbols
https://www.youtube.com/watch?v=ScTyxXA8SA8&list=PL7FuXFaDeEX0sQ0Zhwk2ixfwS1P6e0iuW&index=5

src/style.css Outdated
background-color: #ddd;
padding: 10px;
border: 1px solid #e95d49;
margin: 0;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you've already add margin: 0 to all elements on the page

Suggested change
margin: 0;

src/style.css
Comment on lines +6 to +10
* {
box-sizing: border-box;
padding: 0;
margin: 0;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this styles up (before body)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliceblunt8 aliceblunt8 aliceblunt8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YevgeniyaVoronina @aliceblunt8