Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit #778

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

commit #778

wants to merge 5 commits into from

Conversation

bohdanmayor
Copy link

@bohdanmayor bohdanmayor commented Apr 25, 2023

src/index.html Outdated
<fieldset class="fieldset">
<legend>An interesting fact about you!</legend>
<div class="field">
<label for="yes">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant label. with this label click on text Do you love cats select first radio button

type="email"
id="user-email"
placeholder="[email protected]"
>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a name attribute to the email input element so it can be submitted with the form. For example: name="email"

type="password"
id="user-password"
minlength="6"
>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a name attribute to the password input element so it can be submitted with the form. For example: name="password"

<label for="color">
What is your favorite color?
<input type="color" id="color">
</label>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a name attribute to the color input element so it can be submitted with the form. For example: name="favorite-color"

type="time"
id="time"
step="1"
>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a name attribute to the time input element so it can be submitted with the form. For example: name="bed-time"

<label class="field" for="comments">
Comments:
<textarea id="comments"></textarea>
</label>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a name attribute to the textarea element so it can be submitted with the form. For example: name="comments"

<div class="field">
<label for="accept-term">
I accept the term of the agreement
<input type="checkbox" id="accept-term">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a name attribute to the checkbox input element so it can be submitted with the form. For example: name="accept-term"

@bohdanmayor bohdanmayor requested a review from etojeDenys April 26, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants