Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created html page with form #779

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sheva10barca
Copy link

src/index.html Outdated
<fieldset class="form-fieldset">
<legend>An interesting fact about you!</legend>

<label class="form-label">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now there is a bug: click on Do you love cats select first radio input.
replace on div here and wrap each input in label.

Suggested change
<label class="form-label">
<div class="form-label">

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment on lines +7 to +12
.form-fieldset {
margin-bottom: 20px;
}

.form-label:last-child {
margin-bottom: 0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.form-fieldset {
margin-bottom: 20px;
}
.form-label:last-child {
margin-bottom: 0;
.form-label:not(:last-child) {
margin-bottom: 20px;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants