Human-Rights-01 #693
Open
Human-Rights-01 #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provolovskyi-illia
commented
Mar 22, 2021
provolovskyi-illia
commented
- DEMO LINK
- TEST REPORT LINK
aliceblunt8
suggested changes
Mar 22, 2021
src/index.html
Outdated
| effective recognition and observance, both among the peoples of Member States | ||
| themselves and among the peoples of territories under their jurisdiction. | ||
| </p> | ||
| <h2 class="style-article">Article 1</h2> |
There was a problem hiding this comment.
style-article is not the best class name, let's rename to subtitle
src/index.html
Outdated
Comment on lines
119
to
123
| <li> | ||
| Everyone charged with a penal offence has the right to be presumed | ||
| innocent until proved guilty according to law in a public trial at which he | ||
| has had all the guarantees necessary for his defence. | ||
| </li> |
There was a problem hiding this comment.
don't forget about indentation for text
Suggested change
| <li> | |
| Everyone charged with a penal offence has the right to be presumed | |
| innocent until proved guilty according to law in a public trial at which he | |
| has had all the guarantees necessary for his defence. | |
| </li> | |
| <li> | |
| Everyone charged with a penal offence has the right to be presumed | |
| innocent until proved guilty according to law in a public trial at which he | |
| has had all the guarantees necessary for his defence. | |
| </li> |
src/style.css
Outdated
| font-weight: normal; | ||
| } | ||
|
|
||
| .style-link { |
src/style.css
Outdated
|
|
||
| .heading { | ||
| font-size: 17px; | ||
| font-weight: bold; |
There was a problem hiding this comment.
font-weight: bold is a default setting for h1, remove
There was a problem hiding this comment.
corrected all comments
aliceblunt8
approved these changes
Mar 23, 2021
Comment on lines
+1
to
+3
| html { | ||
| margin: 0; | ||
| } |
There was a problem hiding this comment.
it's better to add margin: 0 to specific elements
like this
.heading,
.paragraph {
margin: 0;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.