Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #702

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Develop #702

wants to merge 4 commits into from

Conversation

Namart
Copy link

@Namart Namart commented Mar 22, 2021

Copy link

@aionova aionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start!

src/index.html Outdated
Comment on lines 14 to 19
<p>
Whereas recognition of the inherent dignity and of the equal and inalienable
rights of all members of the human family is the foundation of freedom, justice
and peace in the world,
<br>
Whereas disregard and contempt for human rights have resulted in barbarous
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>
Whereas recognition of the inherent dignity and of the equal and inalienable
rights of all members of the human family is the foundation of freedom, justice
and peace in the world,
<br>
Whereas disregard and contempt for human rights have resulted in barbarous
<p>
Whereas recognition of the inherent dignity and of the equal and inalienable
rights of all members of the human family is the foundation of freedom, justice
and peace in the world,
<br>
Whereas disregard and contempt for human rights have resulted in barbarous

Format it this way everywhere

src/index.html Outdated
Comment on lines 75 to 77
<p>No one shall be held in slavery or servitude; slavery and the slave trade shall be
prohibited in all their forms.
</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>No one shall be held in slavery or servitude; slavery and the slave trade shall be
prohibited in all their forms.
</p>
<p>
No one shall be held in slavery or servitude; slavery and the slave trade shall be
prohibited in all their forms.
</p>

If an element takes more than 1 line, format it this way

src/index.html Outdated
entitled to protection by society and the State.
</li>
</ol>
<h2><a href="https://www.ohchr.org/EN/UDHR/Documents/UDHR_Translations/eng.pdf">Articles 17 to 30</a></h2>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h2><a href="https://www.ohchr.org/EN/UDHR/Documents/UDHR_Translations/eng.pdf">Articles 17 to 30</a></h2>
<h2>
<a href="https://www.ohchr.org/EN/UDHR/Documents/UDHR_Translations/eng.pdf">
Articles 17 to 30
</a>
</h2>

That's the way we nest tags

font-size: 17px;
}

h2 {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In next tasks please style classes, not tags

src/index.html Outdated
Comment on lines 91 to 96
<p>
All are equal before the law and are entitled without any discrimination to equal
protection of the law. All are entitled to equal protection against any
discrimination in violation of this Declaration and against any incitement to such
discrimination.
</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>
All are equal before the law and are entitled without any discrimination to equal
protection of the law. All are entitled to equal protection against any
discrimination in violation of this Declaration and against any incitement to such
discrimination.
</p>
<p>
All are equal before the law and are entitled without any discrimination to equal
protection of the law. All are entitled to equal protection against any
discrimination in violation of this Declaration and against any incitement to such
discrimination.
</p>

src/index.html Outdated
Comment on lines 114 to 117
<li>Everyone charged with a penal offence has the right to be presumed
innocent until proved guilty according to law in a public trial at which he
has had all the guarantees necessary for his defence.
</li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>Everyone charged with a penal offence has the right to be presumed
innocent until proved guilty according to law in a public trial at which he
has had all the guarantees necessary for his defence.
</li>
<li>
Everyone charged with a penal offence has the right to be presumed
innocent until proved guilty according to law in a public trial at which he
has had all the guarantees necessary for his defence.
</li>

fix it everywhere

src/index.html Outdated
Comment on lines 63 to 71
<p>
Everyone is entitled to all the rights and freedoms set forth in this Declaration,
without distinction of any kind, such as race, colour, sex, language, religion,
political or other opinion, national or social origin, property, birth or other status.
Furthermore, no distinction shall be made on the basis of the political,
jurisdictional or international status of the country or territory to which a person
belongs, whether it be independent, trust, non-self-governing or under any other
limitation of sovereignty.
</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>
Everyone is entitled to all the rights and freedoms set forth in this Declaration,
without distinction of any kind, such as race, colour, sex, language, religion,
political or other opinion, national or social origin, property, birth or other status.
Furthermore, no distinction shall be made on the basis of the political,
jurisdictional or international status of the country or territory to which a person
belongs, whether it be independent, trust, non-self-governing or under any other
limitation of sovereignty.
</p>
<p>
Everyone is entitled to all the rights and freedoms set forth in this Declaration,
without distinction of any kind, such as race, colour, sex, language, religion,
political or other opinion, national or social origin, property, birth or other status.
Furthermore, no distinction shall be made on the basis of the political,
jurisdictional or international status of the country or territory to which a person
belongs, whether it be independent, trust, non-self-governing or under any other
limitation of sovereignty.
</p>

fix everywhere pls)

Copy link

@aionova aionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Comment on lines +183 to +186
<a
href="https://www.ohchr.org/EN/UDHR/Documents/UDHR_Translations/eng.pdf">
Articles 17 to 30
</a>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a
href="https://www.ohchr.org/EN/UDHR/Documents/UDHR_Translations/eng.pdf">
Articles 17 to 30
</a>
<a href="https://www.ohchr.org/EN/UDHR/Documents/UDHR_Translations/eng.pdf">
Articles 17 to 30
</a>

You should put attribute on a new line only if they don't fit in 1 line or there are more than 3 attributes. Otherwise, format it this way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants