Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1877

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Develop #1877

wants to merge 10 commits into from

Conversation

diachkinainna
Copy link

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. disable the scroll if the menu is open
image
  1. add some favicon
image
  1. number should appear on hover
image
  1. in mockup we don't have those bullets
image
  1. disable textarea resizing
image
  1. should be links
image
  1. don't forget to follow this file https://github.com/diachkinainna/layout_landing-page/blob/develop/checklist.md

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍
Let's improve your page

  1. Add topical title and favicon on the page
image
  1. Fix position for the phone number, check it on the design
image
  1. The prices must be are on the same horizontal line
image
  1. Fix default background color for this button and add cursor pointer here
image
  1. Change the autofill styles for the form fields
    https://css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers/
image
  1. Fix font weight here
image
  1. Hide the additional phone number on the mobile and tablet versions
image

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants