Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LandingBike #1878

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ indent_style = space
indent_size = 2
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
insert_final_newline = false
end_of_line = lf
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
/backstop_data
/dist
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module.exports = {
extends: ['@mate-academy/eslint-config', 'plugin:cypress/recommended'],
extends: '@mate-academy/eslint-config',
};
29 changes: 29 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
- name: Upload HTML report(backstop data)
if: ${{ always() }}
uses: actions/upload-artifact@v2
with:
name: report
path: backstop_data
5 changes: 1 addition & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,7 @@ node_modules
.DS_Store

# Generated files
backstop_data
dist
.cache
.parcel-cache
raw_reports
cypress/screenshots
cypress/videos
reports
1 change: 1 addition & 0 deletions .stylelintignore
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
/backstop_data/
/dist
30 changes: 12 additions & 18 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,15 @@
# Landing page
# MyBIKE landing

> ❗❗ You will complete this task in the topic **Landing**.
> Now just choose a design and do the parts from the videos
# Description
This is a modern, fully responsive one-page landing website built using HTML and SCSS. The project utilizes Parcel as a build tool to optimize performance and streamline development. Code quality is ensured with tools like StyleLint, HTMLLint, and BEMLint, maintaining clean and consistent code. The BEM methodology is applied to ensure scalable and maintainable CSS structure. The design is adaptive, providing an excellent user experience across all devices and screen sizes.

Choose a design for your landing page:
- [MET landing](https://www.figma.com/file/lSR1m42L9YwzQwzzxKwHpw/THE-MET)
- [MYBIKE landing](https://www.figma.com/file/NZQAIydtHo5QkINyGLHNcq/BIKE-New-Version?node-id=0%3A1)
- [B&O](https://www.figma.com/file/DtkQmQ797hk0nI4KfMi2Uq/BOSE-New-Version?type=design&node-id=6817-212&t=ZTV6Gl8NzaWkJ4FK-0)
- [Nothing](https://www.figma.com/file/DtkQmQ797hk0nI4KfMi2Uq/BOSE-New-Version?type=design&node-id=6802-139&t=L7eKz5YKLN0m5WxR-0)
# Technologies
- **HTML**: Page markup.
- **SCSS**: Component styling, using mixins, variables, nesting, and other SCSS features.
- **Parcel**: A tool for project bundling and optimization.
- **StyleLint, HTMLLint, BEMLint**: For checking code compliance with standards.

Follow the videos in this and next lessons to implement the page block by block
- Here is [the design from the video](https://www.figma.com/file/DtkQmQ797hk0nI4KfMi2Uq/BOSE-New-Version?type=design&node-id=6703-88&t=L7eKz5YKLN0m5WxR-0) (❗❗ DO NOT implement this design ❗❗ choose one of the options above ❗❗ ☝️)
- Start writing styles in the `main.scss` file. It is be explained in the `Sass` lesson
- **DON'T** try to do it `Pixel Perfect` - implement it the most `simple` way so it looks similar;
- When done check yourself using the [CHECKLIST](./checklist.md) when finished;
- Deploy and create a Pull Request with a [DEMO LINK](https://<your_account>.github.io/layout_landing-page/)

# Tips & Hints
- Check `background-image: url()` to be relative to the `main.scss`. So should start with `../images`.
- If some points from the checklist are not relevant to your design, just skip it.
# Links
- **Project preview:** [DEMO LINK](https://Linkoln223.github.io/layout_landing-page/)
- **GitHub** (https://github.com/Linkoln223/layout_landing-page)
- **Figma design** [View design](https://www.figma.com/design/NZQAIydtHo5QkINyGLHNcq/BIKE-New-Version?node-id=0-1&p=f&t=sJhGo7z3N7L9NSYK-0)
Loading